feat: New preferences page design #6526

PrimaelQuemerais · 2025-04-06T17:42:28Z

What

This PR introduces a new implementation for the preferences page. Some work is still required to complete the transition, but all previously existing pages are accessible through the new design so this PR is already usable.

Screenshot

Screen.Recording.2025-04-26.at.4.44.34.PM.mov

…smooth-app into preferences_v2

…ed styling and navigation functionality

…mprove navigation handling + upgraded sentry_flutter

…into openfoodfacts-develop

…er experience in preferences_v2

…referencesRoot class

… bar for logged in/out states

monsieurtanuki · 2025-04-07T06:24:04Z

Hi @PrimaelQuemerais!
Before an actual review, please fix those warnings:

packages/smooth_app/lib/l10n/app_en.arb

packages/smooth_app/lib/pages/preferences_v2/app_bars/search_bottom_bar.dart

teolemon · 2025-07-04T12:28:12Z

@PrimaelQuemerais linting issues

9s
Run dart format --set-exit-if-changed .
Formatted packages/smooth_app/lib/generic_lib/widgets/app_bars/app_bar_background.dart
Formatted packages/smooth_app/lib/generic_lib/widgets/app_bars/logged_in/app_bar_statistics_card.dart
Formatted packages/smooth_app/lib/generic_lib/widgets/app_bars/logged_in/logged_in_app_bar.dart
Formatted packages/smooth_app/lib/generic_lib/widgets/app_bars/logged_in/logged_in_app_bar_body.dart
Formatted packages/smooth_app/lib/generic_lib/widgets/app_bars/logged_in/logged_in_app_bar_header.dart
Formatted packages/smooth_app/lib/generic_lib/widgets/app_bars/logged_out/app_bar_authentication_button.dart
Formatted packages/smooth_app/lib/generic_lib/widgets/app_bars/logged_out/logged_out_app_bar.dart
Formatted packages/smooth_app/lib/generic_lib/widgets/app_bars/search_bottom_bar.dart
Formatted packages/smooth_app/lib/generic_lib/widgets/smooth_text_form_field.dart
Formatted packages/smooth_app/lib/pages/navigator/app_navigator.dart
Formatted packages/smooth_app/lib/pages/preferences/user_preferences_widgets.dart
Formatted packages/smooth_app/lib/pages/preferences_v2/cards/preference_card.dart
Formatted packages/smooth_app/lib/pages/preferences_v2/preferences_page.dart
Formatted packages/smooth_app/lib/pages/preferences_v2/roots/app_settings_root.dart
Formatted packages/smooth_app/lib/pages/preferences_v2/roots/default_root.dart
Formatted packages/smooth_app/lib/pages/preferences_v2/roots/dev_mode_root.dart
Formatted packages/smooth_app/lib/pages/preferences_v2/roots/preferences_root.dart
Formatted packages/smooth_app/lib/pages/preferences_v2/tiles/external_search_tiles/external_search_preference_tile.dart
Formatted packages/smooth_app/lib/pages/preferences_v2/tiles/external_search_tiles/forum_search_preference_tile.dart
Formatted packages/smooth_app/lib/pages/preferences_v2/tiles/external_search_tiles/github_search_preference_tile.dart
Formatted packages/smooth_app/lib/pages/preferences_v2/tiles/external_search_tiles/wiki_search_preference_tile.dart
Formatted packages/smooth_app/lib/pages/preferences_v2/tiles/navigation_preference_tile.dart
Formatted packages/smooth_app/lib/pages/preferences_v2/tiles/preference_tile.dart
Formatted packages/smooth_app/lib/pages/preferences_v2/tiles/toggle_preference_tile.dart
Formatted packages/smooth_app/lib/pages/preferences_v2/tiles/url_preference_tile.dart
Formatted packages/smooth_app/lib/pages/preferences_v2/tiles/value_edition_preference_tile.dart
Formatted 743 files (26 changed) in 8.07 seconds.

teolemon · 2025-07-14T12:26:15Z

@g123k What's missing on this one to be mergeable ?

packages/smooth_app/lib/generic_lib/widgets/app_bars/app_bar_background.dart

packages/smooth_app/lib/generic_lib/widgets/app_bars/logged_in/app_bar_statistics_card.dart

packages/smooth_app/lib/generic_lib/widgets/app_bars/logged_in/logged_in_app_bar_body.dart

packages/smooth_app/lib/generic_lib/widgets/app_bars/logged_out/logged_out_app_bar.dart

g123k · 2025-07-21T10:37:47Z

packages/smooth_app/lib/generic_lib/widgets/app_bars/search_bottom_bar.dart

+  final Paint _paint;
+
+  @override
+  void paint(Canvas canvas, Size size) {


Why do you need this painter?
This is just a rounded decoration

I use it for the top of the widget which has a inward rounded shape

Yes but the top of it, cropped on your screenshot

But it's already implemented in the TopBar widget

I missed that, I can check on my computer tomorrow.
Is this shape applied to any bottom of a TopBar?

Hi @g123k

I checked the code for SmoothTopBar2 but I don't see how it could help me. I'm not sure we are talking about the same thing. I use the CustomPainter to create this shape :

I'm rounding the bottom corners, but I also need the top to have inward corners.

If SmoothTopBar2 doesn't provide what you need. Then implement the footer for this Widget.
This will be used for all new screens.

g123k · 2025-07-28T09:05:26Z

packages/smooth_app/lib/pages/preferences_v2/tiles/value_edition_preference_tile.dart

+      builder: (BuildContext context) {
+        final AppLocalizations appLocalizations = AppLocalizations.of(context);
+
+        return ChangeNotifierProvider<TextEditingController>.value(


Use an AnimatedBuilder, instead of this ChangeNotifier + Consumer (unless this is used on another file)

packages/smooth_app/lib/pages/preferences_v2/tiles/value_edition_preference_tile.dart

g123k · 2025-07-28T09:06:02Z

packages/smooth_app/lib/pages/preferences_v2/tiles/toggle_preference_tile.dart

+class TogglePreferenceTile extends PreferenceTile {
+  const TogglePreferenceTile({
+    super.icon,
+    required super.title,


required on top

g123k · 2025-07-28T09:06:08Z

packages/smooth_app/lib/pages/preferences_v2/tiles/url_preference_tile.dart

+
+class UrlPreferenceTile extends PreferenceTile {
+  const UrlPreferenceTile({
+    required super.icon,


required on top

g123k · 2025-07-28T09:06:14Z

packages/smooth_app/lib/pages/preferences_v2/tiles/value_edition_preference_tile.dart

+class ValueEditionPreferenceTile extends PreferenceTile {
+  const ValueEditionPreferenceTile({
+    super.icon,
+    required super.title,


required on top

g123k · 2025-07-28T09:10:32Z

packages/smooth_app/lib/pages/preferences_v2/roots/app_settings_root.dart

+            title: appLocalizations.crash_reporting_toggle_title,
+            subtitleText: appLocalizations.crash_reporting_toggle_subtitle,
+            state: userPreferences.crashReports,
+            onToggle: (bool value) {


g123k · 2025-07-28T09:10:34Z

packages/smooth_app/lib/pages/preferences_v2/roots/app_settings_root.dart

+            title: appLocalizations.send_anonymous_data_toggle_title,
+            subtitleText: appLocalizations.send_anonymous_data_toggle_subtitle,
+            state: userPreferences.userTracking,
+            onToggle: (bool value) {


g123k · 2025-07-28T09:10:40Z

packages/smooth_app/lib/pages/preferences_v2/roots/app_settings_root.dart

+                  ),
+                ) ??
+                false,
+            onToggle: (bool value) {


g123k · 2025-07-28T09:11:54Z

packages/smooth_app/lib/pages/preferences_v2/cards/preference_card.dart

+      title: title,
+      titleTextStyle: Theme.of(context).textTheme.bodyLarge,
+      child: Column(
+        children: tiles


What are you doing here?
You transform the same object?!?

g123k · 2025-07-28T09:12:31Z

packages/smooth_app/lib/l10n/app_en.arb

+  "dev_mode_enable_preferences_v2_title": "Enable Preferences V2",
+  "@dev_mode_enable_preferences_v2_title": {
+    "description": "Title for the preferences V2 preferences tile"
+  },
+  "dev_mode_enable_preferences_v2_subtitle": "Try out the new design of the preferences screen",
+  "@dev_mode_enable_preferences_v2_subtitle": {
+    "description": "Subtitle for the preferences V2 preferences tile"
+  },


Not needed.
V2 is by default

PrimaelQuemerais added 16 commits March 23, 2025 12:48

feat: Add new preferences page and related components

abfbe97

feat: Add URL and toggle preference tiles to preferences page

9cef9c0

Merge branch 'openfoodfacts:develop' into preferences_v2

434c97d

feat: Refactor preferences page to use new PreferencesRoot component

90238e2

Merge branch 'preferences_v2' of https://github.com/PrimaelQuemerais/…

9966c6a

…smooth-app into preferences_v2

feat: New logged_in_app_bar and enhanced preference tiles with improv…

7e5df96

…ed styling and navigation functionality

Merge branch 'openfoodfacts:develop' into preferences_v2

b77460c

refactor: Update preference tile components to use subtitleText and i…

7c027db

…mprove navigation handling + upgraded sentry_flutter

Merge branch 'develop' of https://github.com/openfoodfacts/smooth-app …

837b791

…into openfoodfacts-develop

Upgraded sentry_flutter

6f7fbfe

Merge branch 'openfoodfacts-develop' into preferences_v2

05ba565

feat: Refactored preferences_root for better modularity and extension

1c4b936

feat: Implemented LoggedOutAppBar and SearchBottomBar for improved us…

5ddb53c

…er experience in preferences_v2

feat: Enhance preferences page with localized titles and new DefaultP…

164b35c

…referencesRoot class

feat: Update preferences page with localized messages and dynamic app…

cf68913

… bar for logged in/out states

Merge branch 'openfoodfacts:develop' into preferences_v2

63a55d8

github-project-automation bot added this to 🤳🥫 The Open Food Facts mobile app (Android & iOS) Apr 6, 2025

github-project-automation bot moved this to 💬 To discuss and validate in 🤳🥫 The Open Food Facts mobile app (Android & iOS) Apr 6, 2025

github-actions bot added 🍎 iOS iOS specific issues or PRs dependencies 🌐 l10n router 🖥️ MacOS labels Apr 6, 2025

github-actions bot assigned PrimaelQuemerais Apr 6, 2025

PrimaelQuemerais requested a review from monsieurtanuki April 6, 2025 17:43

teolemon reviewed Apr 7, 2025

View reviewed changes

packages/smooth_app/lib/l10n/app_en.arb Outdated Show resolved Hide resolved

teolemon reviewed Apr 7, 2025

View reviewed changes

packages/smooth_app/lib/l10n/app_en.arb Outdated Show resolved Hide resolved

teolemon reviewed Apr 7, 2025

View reviewed changes

packages/smooth_app/lib/l10n/app_en.arb Outdated Show resolved Hide resolved

teolemon reviewed Apr 7, 2025

View reviewed changes

packages/smooth_app/lib/pages/preferences_v2/app_bars/search_bottom_bar.dart Outdated Show resolved Hide resolved

PrimaelQuemerais removed ✏️ Editing - 📦 Packaging input Prices 🔁 Background tasks OCR page 🤳🥫 ZXing ⚙️🥗 Food preferences 🖥️ MacOS 📖 Knowledge panels - Map widget autocomplete labels Jul 3, 2025

Merge branch 'develop' into preferences_v2

3a2c78a

github-actions bot added 🌐 l10n PR: needs rebase and removed PR: needs rebase labels Jul 3, 2025

PrimaelQuemerais and others added 3 commits July 9, 2025 09:34

Merge branch 'openfoodfacts:develop' into preferences_v2

9fa4a31

fix: formating

e767077

fix: imports

09b533c

github-actions bot added the PR: needs rebase label Jul 12, 2025

Merge branch 'develop' into preferences_v2

10607cf

github-actions bot removed the PR: needs rebase label Jul 14, 2025

PrimaelQuemerais and others added 2 commits July 19, 2025 18:05

Merge branch 'openfoodfacts:develop' into preferences_v2

3b718eb

Merge branch 'develop' into preferences_v2

c94ef08

g123k requested changes Jul 21, 2025

View reviewed changes

github-project-automation bot moved this from Backlog to Ready in 💸 Open Prices Jul 21, 2025

github-project-automation bot moved this from To triage to In Progress in 🤖 Artificial Intelligence @ Open Food Facts Jul 21, 2025

PrimaelQuemerais added 2 commits July 21, 2025 14:01

Addressing review comments

e3b6d40

Fixed analyzer issue

82df5f9

g123k requested changes Jul 28, 2025

View reviewed changes

Uh oh!

feat: New preferences page design #6526

Are you sure you want to change the base?

feat: New preferences page design #6526

Uh oh!

Conversation

PrimaelQuemerais commented Apr 6, 2025 • edited by teolemon Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What

Screenshot

Uh oh!

monsieurtanuki commented Apr 7, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

teolemon commented Jul 4, 2025

Uh oh!

teolemon commented Jul 14, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

PrimaelQuemerais commented Apr 6, 2025 •

edited by teolemon

Loading