Skip to content

feat: Credential/Password sharing for android and website #6504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

Abhishek-P0207
Copy link
Contributor

What

  • Through this PR, the user is now able to share his credentials between the app and website.
  • Thing to note is that, the pop-up will appear only if the account in which the credential is stored, is present in both the phone and computer.

Screenshot

In Website
Screenshot 2025-03-31 093037
Screenshot 2025-03-31 093048

In App

Fixes bug(s)

Part of

@codecov-commenter
Copy link

codecov-commenter commented Mar 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 5.88%. Comparing base (4d9c7fc) to head (5e12da0).
Report is 815 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #6504      +/-   ##
==========================================
- Coverage     9.54%   5.88%   -3.67%     
==========================================
  Files          325     496     +171     
  Lines        16411   29543   +13132     
==========================================
+ Hits          1567    1739     +172     
- Misses       14844   27804   +12960     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@teolemon teolemon requested a review from a team April 1, 2025 07:06
@teolemon teolemon added the 👥 User management Account login, signup, signout label Apr 1, 2025
@g123k
Copy link
Collaborator

g123k commented Apr 3, 2025

@Abhishek-P0207 Have you checked that the feature works?

@Abhishek-P0207
Copy link
Contributor Author

Abhishek-P0207 commented Apr 3, 2025

I checked it, the passwords are getting saved, but the thing is, if a user creates an account in mobile and saves the credentials, then it is saved as scanner.openfoodfacts.org (which is correct) and if through web it is saved under openfoodfacts.org (which is correct)

WhatsApp Image 2025-04-03 at 10 52 31 PM

But, the usual pop-up doesn't come due to this. But in the Docs it is written that it will work only after deployed.

Screenshot 2025-04-03 225531

@Abhishek-P0207
Copy link
Contributor Author

In the assentlinks.json, there is an error

Screenshot 2025-04-03 232130

The package_name should be scanner.openfoodfacts.org.

@g123k
Copy link
Collaborator

g123k commented Apr 5, 2025

org.openfoodfacts.scanner is the correct package name on the Google Play: https://play.google.com/store/apps/details?id=org.openfoodfacts.scanner

Have you checked with this package name if it works?

@Abhishek-P0207
Copy link
Contributor Author

Sry,I was unavailable due to class tests.I will look into it and say!!

@g123k
Copy link
Collaborator

g123k commented Apr 14, 2025

Sry,I was unavailable due to class tests.I will look into it and say!!

Any update?

@Abhishek-P0207
Copy link
Contributor Author

@g123k Sry for the delay in responding. There are Lab exams going on now, it will be over by day after tmrw, so I will be free after that. I will look into it and say.
Thank you.

@teolemon
Copy link
Member

I enabled a lot of toggles for Credential sharing in the Google Play Developper console.
image
image

@g123k
Copy link
Collaborator

g123k commented May 5, 2025

Before implementing this, we should instead have a reliable autofill mechanism.
The Credential Manager is a first step, and I'm not fully sure, but maybe a mandatory step for credential sharing.

@Abhishek-P0207
Copy link
Contributor Author

Yeah, I will have a look into this

@Abhishek-P0207
Copy link
Contributor Author

Abhishek-P0207 commented May 6, 2025

If everything is properly setup, then google password manager will pop-up if there is a saved credential for that site
From there its a matter of just clicking that pop-up to auto fill and this is very reliable according to me, but i will see the package you have mentioned.

@teolemon teolemon moved this from 💬 To discuss and validate to Pull Requests in 🤳🥫 The Open Food Facts mobile app (Android & iOS) Jul 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android 👥 User management Account login, signup, signout
Projects
Development

Successfully merging this pull request may close these issues.

Implement Credential Sharing with the Website
4 participants