refactor: highlighted indicators for incomplete fields #6497
Conversation
github-project-automation
bot
moved this to 💬 To discuss and validate
in 🤳🥫 The Open Food Facts mobile app (Android & iOS)
|
Hi @khushi-hura! |
|
I am sorry for the errors @monsieurtanuki there was a huge system lag which didn't show this up, I will commit this in a few hours! |
|
In terms of UI, please have a better look at the mockups, there are some inconsistencies:
|
|
The changes now closely resemble the mockup!
|
|
@khushi-hura : 🔴 Errors info • Missing type annotation • packages/smooth_app/lib/generic_lib/widgets/smooth_list_tile_card.dart:67:23 • always_specify_types |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6497 +/- ##
==========================================
- Coverage 9.54% 5.84% -3.71%
==========================================
Files 325 497 +172
Lines 16411 29825 +13414
==========================================
+ Hits 1567 1743 +176
- Misses 14844 28082 +13238 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
hey @teolemon hope it works now! 😊 |
|
There are still some issues with the UI.
|
|
|
|
@khushi-hura 2 conflicts to solve |
|
@khushi-hura did you take @g123k 's comments into account ? |
yes @teolemon we also had a discussion on slack and I tried my best to align everything according to the mockup provided by @g123k and also corrected the UI bugs mentioned in previous comment. |
teolemon
moved this from 💬 To discuss and validate
to Pull Requests
in 🤳🥫 The Open Food Facts mobile app (Android & iOS)
This pull request addresses issue #5820
This refactoring makes it easy for user to identify the incomplete fields for a particular product by addressing errors or warnings in the missing fields.
A sorting feature is also introduced which helps the user to sort by missing data and sort by fields:
SORT BY FIELDS:
SORT BY MISSING DATA:
