Skip to content

docs: a few fixes in the comments for Nutriscore #12171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jforget
Copy link
Contributor

@jforget jforget commented Jul 24, 2025

A few fixes in the comments.

Some remarks. I do not know what is the use of the
[nutrient]_points_max property, so the comment contains question
marks.

In the 2023 version, I have added a comment for nutrient salt but I
have not removed sodium. The provisional comment for salt contains
only question marks, please write something interesting.

There is a problem with the signatures of functions
get_value_with_one_less_negative_point_2023 and
get_value_with_one_more_positive_point_2023, but it is given in a
separate issue.

@codecov-commenter
Copy link

codecov-commenter commented Jul 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 50.64%. Comparing base (3e0999a) to head (5c6839e).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12171   +/-   ##
=======================================
  Coverage   50.64%   50.64%           
=======================================
  Files          90       90           
  Lines       24145    24145           
  Branches     5804     5804           
=======================================
  Hits        12229    12229           
  Misses      10403    10403           
  Partials     1513     1513           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@stephanegigandet stephanegigandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@github-project-automation github-project-automation bot moved this from Todo to In Progress in 🚦Nutri-Score Jul 24, 2025
@github-project-automation github-project-automation bot moved this from To discuss and validate to Done in 🍊 Open Food Facts Server issues Jul 24, 2025
@stephanegigandet stephanegigandet enabled auto-merge (squash) July 24, 2025 10:17
@stephanegigandet
Copy link
Contributor

/lint

@stephanegigandet
Copy link
Contributor

Thanks for the PR. Could you run "make lint"? The /lint command only works for branches on the OFF repo, not forked repos.

@teolemon
Copy link
Member

/lint

Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

4 participants