-
-
Notifications
You must be signed in to change notification settings - Fork 479
docs: a few fixes in the comments for Nutriscore #12171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12171 +/- ##
=======================================
Coverage 50.64% 50.64%
=======================================
Files 90 90
Lines 24145 24145
Branches 5804 5804
=======================================
Hits 12229 12229
Misses 10403 10403
Partials 1513 1513 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
/lint |
Thanks for the PR. Could you run "make lint"? The /lint command only works for branches on the OFF repo, not forked repos. |
/lint |
|
A few fixes in the comments.
Some remarks. I do not know what is the use of the
[nutrient]_points_max
property, so the comment contains questionmarks.
In the 2023 version, I have added a comment for nutrient
salt
but Ihave not removed
sodium
. The provisional comment forsalt
containsonly question marks, please write something interesting.
There is a problem with the signatures of functions
get_value_with_one_less_negative_point_2023
andget_value_with_one_more_positive_point_2023
, but it is given in aseparate issue.