Add custom build flags to docker

[simonoff]

Signed-off-by: Oleksandr Simonov [email protected]

The reason for this change is because i have this function depends on a private pypi repository on github which requires a providing ssh key inside Dockerfile. To avoid put sensitive data into the images, i decided to make this change to take the benifit of using docker buildkit secrets and ssh support.

Description

In our work we required to have ability to fetch a private libraries for Python through GitHub repo.
I have made a research and have found that there are already a discussion #785 and PR #786. But PR is too specific and in discussion a proposal for more generic variant. So I have added ability to provide a custom arguments to docker build like --ssh or --secret

Example usage for now is next:

faas-cli build --build-flags "--ssh default"

Motivation and Context

Provide ability to fetch from any secure package storage from any git repository or through secrets to fetch from any private package manager's host.

How Has This Been Tested?

Yes, i have added new tests for such feature.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I've read the CONTRIBUTION guide
• I have signed-off my commits with git commit -s
• I have added tests to cover my changes.
• All new and existing tests passed.

[simonoff]

@carlosedp @gliptak @johnmccabe @leodido anyone can take a look on PR?

[carlosedp]

I like the idea of getting all build parameter together into the BuildImageConfig type. Also the ability to have flexible build flags suits some use cases mentioned in the linked issues.

/LGTM

[alexellis]

@simonoff this is with our team for consideration. Thanks again for your interest in OpenFaaS.

[alexellis]

Please see note at: #785 (comment)

Feel free to get in touch for a call, if that's of interest?

[alexellis]

/lock: resolved