-
-
Notifications
You must be signed in to change notification settings - Fork 53
Resolve parameters completely from stubs when inspect.signature fails #698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #698 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 22 22
Lines 6771 6792 +21
=========================================
+ Hits 6771 6792 +21 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
Files not reviewed (1)
- CHANGELOG.rst: Language not supported
Comments suppressed due to low confidence (1)
jsonargparse/_parameter_resolvers.py:1112
- [nitpick] Consider storing the result of 'get_component_and_parent' in a variable for clarity and potential reuse rather than calling it solely for verification.
get_component_and_parent(function_or_class, method_or_property) # verify input
28079fa
to
668cdfa
Compare
668cdfa
to
a35338f
Compare
|
What does this PR do?
When combined with JelleZijlstra/typeshed_client#118 would eventually resolve torch functions (#546).
Before submitting