Skip to content

Resolve parameters completely from stubs when inspect.signature fails #698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 18, 2025

Conversation

mauvilsa
Copy link
Member

@mauvilsa mauvilsa commented Mar 28, 2025

What does this PR do?

When combined with JelleZijlstra/typeshed_client#118 would eventually resolve torch functions (#546).

Before submitting

  • Did you read the contributing guideline?
  • [n/a] Did you update the documentation? (readme and public docstrings)
  • Did you write unit tests such that there is 100% coverage on related code? (required for bug fixes and new features)
  • Did you verify that new and existing tests pass locally?
  • Did you make sure that all changes preserve backward compatibility?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

@mauvilsa mauvilsa added the enhancement New feature or request label Mar 28, 2025
Copy link

codecov bot commented Mar 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (295919d) to head (a35338f).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #698   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           22        22           
  Lines         6771      6792   +21     
=========================================
+ Hits          6771      6792   +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.

Files not reviewed (1)
  • CHANGELOG.rst: Language not supported
Comments suppressed due to low confidence (1)

jsonargparse/_parameter_resolvers.py:1112

  • [nitpick] Consider storing the result of 'get_component_and_parent' in a variable for clarity and potential reuse rather than calling it solely for verification.
get_component_and_parent(function_or_class, method_or_property)  # verify input

Copy link

@mauvilsa mauvilsa merged commit 7637f7f into main Apr 18, 2025
29 checks passed
@mauvilsa mauvilsa deleted the issue-546-stubs-only-resolver branch April 18, 2025 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant