-
-
Notifications
You must be signed in to change notification settings - Fork 53
Support parsing optionals as positionals #692
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #692 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 22 22
Lines 6694 6755 +61
=========================================
+ Hits 6694 6755 +61 ☔ View full report in Codecov by Sentry. |
could we bump the version to an RC or something so I can test it with our CI - Lightning-AI/utilities#371 |
This looks good https://github.com/Lightning-AI/utilities/blob/9610d5bfa0a639d0820ef525e5cec06b0db71e11/requirements/cli.txt#L1, I think there is no need for an RC. |
2d0a74a
to
05328f1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added more tests and documentation for the feature. But it is still pending to not support this for subclass and dataclass types. What to do regarding shtab can be a future improvement.
|
What does this PR do?
Fixes #690
Before submitting