Skip to content

feat(api-service): create traces e2e fixes NV-6218 #8662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: next
Choose a base branch
from

Conversation

djabarovgeorge
Copy link
Contributor

What changed? Why was the change needed?

Screenshots

Expand for optional sections

Related enterprise PR

Special notes for your reviewer

- Introduced ClickHouse client integration for analytics logging.
- Added cleanup functions for ClickHouse database and tables.
- Updated environment configuration for ClickHouse connection.
- Implemented E2E tests for logging requests with filtering capabilities.
- Refactored request log mapping to utilize a dedicated mapper function.
@djabarovgeorge djabarovgeorge changed the title feat(api-service): create traces e2e feat(api-service): create traces e2e fixes NV-6218 Jul 8, 2025
Copy link

netlify bot commented Jul 8, 2025

Deploy preview added

Name Link
🔨 Latest commit 0504ecb
🔍 Latest deploy log https://app.netlify.com/projects/dashboard-v2-novu-staging/deploys/686e7ad77254ae0008d231a3
😎 Deploy Preview https://deploy-preview-8662.dashboard-v2.novu-staging.co
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

- Refactored ClickHouse startup configuration in GitHub Actions to use Docker image.
- Enhanced E2E setup with improved ClickHouse connection management and cleanup functions.
- Updated environment variables for ClickHouse user and password.
- Improved error handling and logging in ClickHouse service methods.
- Replaced manual ClickHouse startup configuration with a reusable action.
- Updated environment variable handling for ClickHouse integration.
- Improved clarity and maintainability of the GitHub Actions setup.
- Introduced a new E2E test suite for verifying activity traces in notifications.
- Implemented tests to ensure correct behavior when the traces feature flag is enabled and when it fails.
- Updated environment variables to enable trace logging for testing purposes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant