-
Notifications
You must be signed in to change notification settings - Fork 4.1k
feat(api-service): create traces e2e fixes NV-6218 #8662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
djabarovgeorge
wants to merge
6
commits into
next
Choose a base branch
from
create-trace-e2e
base: next
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced ClickHouse client integration for analytics logging. - Added cleanup functions for ClickHouse database and tables. - Updated environment configuration for ClickHouse connection. - Implemented E2E tests for logging requests with filtering capabilities. - Refactored request log mapping to utilize a dedicated mapper function.
✅ Deploy preview added
To edit notification comments on pull requests, go to your Netlify project configuration. |
- Refactored ClickHouse startup configuration in GitHub Actions to use Docker image. - Enhanced E2E setup with improved ClickHouse connection management and cleanup functions. - Updated environment variables for ClickHouse user and password. - Improved error handling and logging in ClickHouse service methods.
- Replaced manual ClickHouse startup configuration with a reusable action. - Updated environment variable handling for ClickHouse integration. - Improved clarity and maintainability of the GitHub Actions setup.
- Introduced a new E2E test suite for verifying activity traces in notifications. - Implemented tests to ensure correct behavior when the traces feature flag is enabled and when it fails. - Updated environment variables to enable trace logging for testing purposes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
Screenshots
Expand for optional sections
Related enterprise PR
Special notes for your reviewer