Skip to content

docs(api): correct description for /credentials endpoints #8659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: next
Choose a base branch
from

Conversation

denissafiullin-deriv
Copy link

This pull request updates the descriptions and summaries of two API to reflect their actual functionality:

  • PATCH /credentials
  • PUT /credentials

What changed? Why was the change needed?

PUT upserts credentials, while PATCH not only partially updates, but creates credentials as well.

Copy link

netlify bot commented Jul 8, 2025

👷 Deploy request for dashboard-v2-novu-staging pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit f846f37

@denissafiullin-deriv denissafiullin-deriv changed the title Update /credentials endpoint description docs: correct description for /credentials endpoints Jul 8, 2025
@denissafiullin-deriv denissafiullin-deriv changed the title docs: correct description for /credentials endpoints docs(api): correct description for /credentials endpoints Jul 8, 2025
@scopsy
Copy link
Contributor

scopsy commented Jul 8, 2025

Thank you @denissafiullin-deriv , @jainpawan21 I believe this is a similar change to your recent PR?

@denissafiullin-deriv
Copy link
Author

Thank you @denissafiullin-deriv , @jainpawan21 I believe this is a similar change to your recent PR?

It's a subsequent change to the previous PRs to clarify the functionality of the endpoint based on the HTTP verb.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants