feat(dashboard,api-service): layout editor preview fixes NV-6219 #8658
+348
−55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dashboard-v2-novu-staging canceled.
|
github-actions
bot
changed the title
LetItRock
commented
Jul 7, 2025
| body: email?.body, | ||
| editorType: email?.editorType, | ||
| layoutId: null, | ||
| body: enhanceBodyForPreview(editorType, body), |
There was a problem hiding this comment.
This is the important part where we adjust the "layout body" and replace the {{content}} variable with the div placeholder or for the Maily - placeholder node.
| * ] | ||
| * } | ||
| */ | ||
| export const replaceMailyNodesByCondition = ( |
There was a problem hiding this comment.
the helper util that allows you with matching condition replace the Maily node
Comment on lines
+36
to
+44
| const form = useForm({ | ||
| defaultValues, | ||
| values, | ||
| shouldFocusError: false, | ||
| resetOptions: { | ||
| keepDirtyValues: true, | ||
| }, | ||
| }); | ||
| const controlValues = useWatch({ control: form.control }); |
There was a problem hiding this comment.
moved the form to be inside here as I need to watch on the control value changes and do the preview request
| import { useLayoutEditor } from './layout-editor-provider'; | ||
| import { EmailCorePreview } from '../workflow-editor/steps/preview/previews/email-preview-wrapper'; | ||
|
|
||
| export const LayoutPreviewFactory = () => { |
There was a problem hiding this comment.
in the future we might have other preview components for example for the in-app layout
| import { useEffect, useState } from 'react'; | ||
| import { useDataRef } from './use-data-ref'; | ||
|
|
||
| export function useDebouncedValue<T>(value: T, delay: number): T { |
There was a problem hiding this comment.
moved from the other component to reusable hook
scopsy
approved these changes
Jul 7, 2025
| `<span style="background: #FFFFFF; border: 1px solid #E1E4EA; border-radius: 4px; padding: 4px 8px; flex; justify-content: center; align-items: center; font-size: 10px; line-height: 1; color: #99A0AE;">${placeholderText}</span>` + | ||
| '</div>'; | ||
|
|
||
| export const enhanceBodyForPreview = (editorType: string, body: string) => { |
There was a problem hiding this comment.
I think it ended up quite nicely!
djabarovgeorge
added a commit
that referenced
this pull request
Jul 8, 2025
- Introduced ClickHouse client integration for analytics logging. - Added cleanup functions for ClickHouse database and tables. - Updated environment configuration for ClickHouse connection. - Implemented E2E tests for logging requests with filtering capabilities. - Refactored request log mapping to utilize a dedicated mapper function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
Related Maily PR
Layout Editor - Preview.
Screenshots