feat(api-service): api for env level change fixes NV-6155 #8608
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dashboard-v2-novu-staging canceled.
|
Updated imports and usage of WorkflowOriginEnum to ResourceOriginEnum in environment and workflow sync logic to align with changes in the shared module. This ensures consistency and compatibility with the updated enum naming.
Enhanced the environment diff logic to include step-level changes (added, modified, deleted, moved) in workflows. Updated DTOs, types, and sync strategies to support detailed step diffs and extended summary statistics. This provides more granular insight into workflow differences between environments.
The diff logic now returns an array of results, each representing a single entity (workflow) with its own entityId, entityName, diffs, and summary. DTOs, types, and tests were updated to reflect this structure, improving clarity and granularity of environment diff results.
Removed separate step-level change counters from diff summary DTOs, types, and aggregation logic. Now, added, modified, deleted, and unchanged counts include both workflows and steps, streamlining the summary structure and reducing redundancy.
Added the @exclude() decorator to the session property in workflow and message template command classes to prevent the session from being serialized in API responses. This change improves security and ensures sensitive session data is not exposed.
The userId is now passed from the controller to the GetMyEnvironmentsCommand. This allows use cases to access the user's ID when retrieving environments.
Refactored environment diff E2E tests to use beforeEach for better isolation. Added null checks for source and target workflows in WorkflowComparator to prevent errors. Marked the session property with @exclude in UpdateWorkflowCommand to avoid serializing it in responses.
Introduces the 'updatedBy' field to WorkflowResponseDto and WorkflowListResponseDto, allowing tracking of the user who last updated a workflow. Adds the 'type' field to EnvironmentResponseDto as an optional property. Also updates related schemas and types in the internal SDK, and exposes the 'slug' field in LayoutResponseDto. Removes @ApiExcludeController from LayoutsController and improves OpenAPI property annotations for user DTOs.
Added the @ApiExcludeController() decorator to prevent the LayoutsController from appearing in the generated Swagger API documentation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
Screenshots
Expand for optional sections
Related enterprise PR
Special notes for your reviewer
Summary by CodeRabbit
New Features
Bug Fixes
Tests