fix(application-generic): Bump got #7399
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SokratisVidros
temporarily deployed
to
Linting
GitHub Actions
Inactive
SokratisVidros
temporarily deployed
to
Linting
GitHub Actions
Inactive
SokratisVidros
temporarily deployed
to
Linting
GitHub Actions
Inactive
✅ Deploy Preview for dev-web-novu ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for dashboard-v2-novu-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+186
to
+189
| const res = await request(url, { | ||
| ...options, | ||
| headers, | ||
| }).json(); | ||
| }); |
Check failure
Code scanning / CodeQL
Server-side request forgery Critical
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix AI 29 days ago
To fix the SSRF vulnerability, we need to ensure that the bridgeUrl is validated against a whitelist of allowed URLs or domains. This can be done by implementing a validation function that checks if the bridgeUrl matches any of the allowed patterns before using it to construct the final URL for the request.
- Implement a validation function that checks if the
bridgeUrlis in a list of allowed URLs or matches a specific pattern. - Use this validation function in the
executemethod ofExecuteBridgeRequestto validatecommand.statelessBridgeUrlbefore constructing thebridgeUrl. - If the URL is not valid, throw an appropriate exception.
Suggested changeset
1
libs/application-generic/src/usecases/execute-bridge-request/execute-bridge-request.usecase.ts
| @@ -120,2 +120,6 @@ | ||
|
|
||
| if (!this.isValidBridgeUrl(command.statelessBridgeUrl)) { | ||
| throw new BadRequestException('Invalid bridge URL'); | ||
| } | ||
|
|
||
| const bridgeUrl = this.getBridgeUrl( | ||
| @@ -494,2 +498,11 @@ | ||
| } | ||
| private isValidBridgeUrl(url: string): boolean { | ||
| const allowedUrls = [ | ||
| 'https://allowed-domain1.com', | ||
| 'https://allowed-domain2.com', | ||
| // Add more allowed URLs or patterns here | ||
| ]; | ||
|
|
||
| return allowedUrls.some((allowedUrl) => url.startsWith(allowedUrl)); | ||
| } | ||
| } |
Copilot is powered by AI and may make mistakes. Always verify output.
Update Got to its latest version to get all fixes and use its timing reporting so as to investigate timeouts with Bridge endpoints
SokratisVidros
force-pushed
the
debug_timeouts
branch
from
5aa45d3 to
c2feabd
Compare
SokratisVidros
temporarily deployed
to
Linting
GitHub Actions
Inactive
SokratisVidros
temporarily deployed
to
Linting
GitHub Actions
Inactive
SokratisVidros
temporarily deployed
to
Linting
GitHub Actions
Inactive
commit: |
|
Got will be bumped as part of the #7424 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
Update Got to its latest version to get all fixes and use its timing reporting so as to investigate timeouts with Bridge endpoints