Add support for push constants. #609
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RubyNova
added
feature
capnkenny
reviewed
May 18, 2025
| size_t offset = 0; | ||
| size_t size = 0; | ||
| }; | ||
| } |
capnkenny
approved these changes
May 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
This adds support for CmdPushConstants for @capnkenny since its needed by imgui.
Is there an open issue that this resolves? If so, please link it here.
No.
What is the current behavior? (You can also link to an open issue here)
You can't use push constants. 😎
What is the new behavior (if this is a feature change)?
you can use push constants. 😎
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No.
Other information:
I haven't written any unit tests for this since its Vulkan API. I've also not actually tested this works as intended myself, because that would require me writing shaders I can't be bothered with to be honest, but the wiring is simple enough I don't think it matters.