Links #4
Merged
Links #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Change import from 'qunit' to '@ember/debug' for assert - Add missing return statement in Path#visits() method - Fix partner relationship name to use correct person (thatPerson instead of thisPerson) - Fix Set.union() usage by using spread operator - Remove duplicate allAncestors() method - Fix method call from getPersonById to populatedPersonById These fixes address runtime errors and incorrect relationship naming. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
…ions - Add test:node script to package.json for running tests without browser - Create mock data factory for building test families - Implement comprehensive relationship tests in Node.js - Add testem.js configuration for browser test runner This allows testing complex relationship logic without requiring a browser environment, making it easier to test edge cases and debug issues. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Add tests for self-relationships (correctly throws error) - Add tests for half-siblings (share only one parent) - Add tests for step-siblings (no shared parents) - Add tests for parent-child relationships - Add tests for missing/null partnership data - Add tests for partners/spouses - Add tests for complex step-relationships - Add tests for double-related cousins (related through both parents) - Add tests for people who are both cousins and step-siblings - Add tests for multi-path complex relationships These tests ensure the relationship calculation handles edge cases correctly and validates all 26 test scenarios pass. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Detect step-siblings by checking if they share any biological parents - Add "step-" prefix to sibling names when no parents are shared - Correctly handle half-siblings (1 shared parent) vs full siblings (2 shared) This improvement helps users understand complex family relationships, especially in blended families where children from different marriages become step-siblings through their parents' new partnership. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Add CLAUDE.md with project overview and key commands - Update README.md with additional project information - Document architecture, data flow, and important notes This helps AI assistants and developers understand the project structure and common development workflows. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Remove outdated CONTEXT.md file - Add justfile for common development commands The CONTEXT.md has been replaced by CLAUDE.md with more comprehensive project documentation. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
…DE.md - Add comprehensive testing infrastructure documentation - Document the Node.js-based headless test suite - Explain test helpers and mock data factory - Note preference for headless testing when possible - Include details about browser testing when necessary This helps future developers and AI assistants understand the testing approach and use the most efficient testing method for their needs. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Create new .github/workflows/ci.yml with three job types: - Rust tests (build, test, check) - JavaScript tests (lint, headless Node.js tests) - Ember tests (full browser test suite) - Update rust.yml to avoid duplication with placeholder job - Headless tests now run automatically on all PRs and main pushes 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Add ESLint, Stylelint, and Ember template-lint configurations that were missing from the repository. This fixes CI failures where linters couldn't find their configuration files. - Add .eslintrc.js with Ember, Node.js, and .gjs file support - Add .stylelintrc.js for CSS linting - Add .template-lintrc.js for Ember template linting - Add corresponding ignore files for all linters 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Add ESLint disable comments for intentional classic component usage - Remove unused imports across components, routes, and services - Convert person-outline-children to template-only component - Fix case declarations with lexical bindings in genea service - Refactor conditional assertions in tests to satisfy QUnit rules - Remove unused variable assignment in genea-test.js These changes ensure all linting checks pass in CI without changing application functionality. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Replace vague "sister or sibling" checks with exact "sister" assertion - Replace vague "aunt or pibling" checks with exact "aunt" assertion - Add reverse relationship test (sister -> brother) - Use strictEqual for more precise test validation These changes make the tests more accurate and ensure the relationship calculation logic returns the expected specific relationship names based on gender. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Format testem.js configuration - Format test helper files - Update pnpm-lock.yaml with tiny-invariant dependency These are automatic formatting changes to ensure consistency across the codebase. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.