Skip to content

Add scanpy/scrublet module #8684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 30 commits into from
Jun 24, 2025
Merged

Add scanpy/scrublet module #8684

merged 30 commits into from
Jun 24, 2025

Conversation

nictru
Copy link
Contributor

@nictru nictru commented Jun 21, 2025

These is the first of 13 scanpy modules. I am adding this as a preparation of the 1.0 release of nf-core/scdownstream

@nictru nictru marked this pull request as ready for review June 22, 2025 09:31
@nictru nictru changed the title Add scanpy/scrublet module Add scanpy/scrublet and scanpy/pca modules Jun 22, 2025
@nictru nictru requested a review from SPPearce June 22, 2025 10:50
Copy link
Contributor

@SPPearce SPPearce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please make separate PRs for each module.

@nictru
Copy link
Contributor Author

nictru commented Jun 23, 2025

I addressed the comments about scrublet and remobed the scanpy/pca module. I am now investigating the stability of the module a bit, maybe I can still get the hashes stable

@nictru
Copy link
Contributor Author

nictru commented Jun 23, 2025

Seems to work

@nictru nictru requested a review from SPPearce June 23, 2025 08:08
@nictru nictru changed the title Add scanpy/scrublet and scanpy/pca modules Add scanpy/scrublet module Jun 23, 2025
@SPPearce
Copy link
Contributor

Can you please make separate PRs for each module.

Oh, sorry, now I read my previous comment I see it wasn't really what I meant to say (I blame it being 6am).
It should have read, "in the future"; this was fine having two modules, just easier if they are separated for reviewing.

@nictru nictru added this pull request to the merge queue Jun 24, 2025
Merged via the queue into nf-core:master with commit 115aacf Jun 24, 2025
38 of 42 checks passed
@nictru nictru deleted the scanpy/scrublet branch June 24, 2025 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants