-
Notifications
You must be signed in to change notification settings - Fork 872
feat: support no reference tumor only cnvkit analysis #8618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The stub test is failing because there is no stub here, can you please add one.
That's not actually why it's failing. In the absence of a stub the script block is executed. This is specifically a bug in nextflow=24.10.2, nextflow-io/nextflow#5456. You can prove this to yourself locally.
mamba create -n nf-core-nextflow25 nf-core nextflow=25.04.2
mamba create -n nf-core-nextflow24 nf-core nextflow=24.10.2
cd modules
git checkout master
git pull
mamba activate nf-core-nextflow25
nf-test test modules/nf-core/cnvkit/batch/tests --profile docker
mamba deactivate
mamba activate nf-core-nextflow24
nf-test test modules/nf-core/cnvkit/batch/tests --profile docker
If you look at the failed actions they're specifically the ones for nextflow=24.20.2. The actions using latest everything pass. That said, I'm happy to add a stub for this. |
Yes, that might be the case, but it will be fixed if you add a stub. |
Note
The failing tests on this PR are only occurring with nextflow=24.10.2 for a single stub test and are due to a known nextflow bug, nextflow-io/nextflow#5456
The
cnvkit/batch
module will now support the recommended mode for running tumor only samples without areference.cnn
file.From the docs:
https://cnvkit.readthedocs.io/en/stable/quickstart.html
PR checklist
nf-core modules test <MODULE> --profile docker
nf-core modules test <MODULE> --profile singularity
nf-core modules test <MODULE> --profile conda