Use new unreadCountStore for setting appIcon Badge #1174
Conversation
| import { onTalkHashDirty, onTalkHashUpdate, openConversation, setTalkHash } from './talk.service.ts' | ||
| import { registerTalkDesktopSettingsSection } from '../Settings/index.ts' | ||
| import { subscribeBroadcast } from '../../../shared/broadcast.service.ts' | ||
| import { appData } from '../../../app/AppData.js' | ||
| import unreadCountStore, { EVENTS } from '@talk/src/store/unreadCountStore' |
There was a problem hiding this comment.
Static import of a @talk module here triggers init of all the related Talk modules before Talk Desktop init is complete. Which may (and will) cause issues.
It should be imported dynamically, like @talk/src/main.js below.
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
markusstoll
force-pushed
the
feature/unreadCountInApplicationBadge
branch
from
5aee265 to
dbce785
Compare
|
I reworked this PR to match the reworked PR on spreed |
Signed-off-by: Markus Stoll <[email protected]>
markusstoll
force-pushed
the
feature/unreadCountInApplicationBadge
branch
from
fc59a90 to
da37046
Compare
|
As with my changes in spreed I squashed all changes into 1 commit |
☑️ Resolves
All changes are described in the mentioned issue