-
Notifications
You must be signed in to change notification settings - Fork 465
Get rid of "[audio|video][On|Off]" datachannel events #397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Also this would mean that any other client (mobile apps, SIP bridge, etc) would have to implement these events to make the (web) UI work correctly. |
I hope this does not interfere with #282 ? |
Not from what I understand. This issue is about detecting if another peer is sending audio / video, #282 is about disabling audio / video of other peers. |
What is the reason for the "signaling" label? There are no changes required for the signaling, all information should already be available from the peerconnections / streams. |
Increased priority as data channels are not supported in Edge 😢 |
We could use the |
Automatically shift popovermenu if out of window
As just discussed offline with @Ivansss : currently the UI sends
videoOn
/videoOff
andaudioOn
/audioOff
events through the datachannels to all connected clients to notify about what is available and what is currently sending.This is not necessary as you can get the information on media types from the offer/answer, and get the state (paused/running) from the streams. In order to remove duplicate functionality and simplify the code, these events should be removed.
The text was updated successfully, but these errors were encountered: