Skip to content

Get rid of "[audio|video][On|Off]" datachannel events #397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fancycode opened this issue Aug 31, 2017 · 6 comments
Open

Get rid of "[audio|video][On|Off]" datachannel events #397

fancycode opened this issue Aug 31, 2017 · 6 comments
Assignees
Labels
1. to develop feature: WebRTC 🚡 WebRTC connection between browsers and/or mobile clients standardisation technical debt
Milestone

Comments

@fancycode
Copy link
Member

As just discussed offline with @Ivansss : currently the UI sends videoOn/videoOff and audioOn/audioOff events through the datachannels to all connected clients to notify about what is available and what is currently sending.

This is not necessary as you can get the information on media types from the offer/answer, and get the state (paused/running) from the streams. In order to remove duplicate functionality and simplify the code, these events should be removed.

@fancycode
Copy link
Member Author

Also this would mean that any other client (mobile apps, SIP bridge, etc) would have to implement these events to make the (web) UI work correctly.

@nickvergessen
Copy link
Member

I hope this does not interfere with #282 ?

@fancycode
Copy link
Member Author

Not from what I understand. This issue is about detecting if another peer is sending audio / video, #282 is about disabling audio / video of other peers.

@nickvergessen nickvergessen added bug feature: signaling 📶 Internal and external signaling backends labels Oct 4, 2017
@fancycode
Copy link
Member Author

What is the reason for the "signaling" label? There are no changes required for the signaling, all information should already be available from the peerconnections / streams.

@nickvergessen nickvergessen added feature: WebRTC 🚡 WebRTC connection between browsers and/or mobile clients and removed feature: signaling 📶 Internal and external signaling backends labels Oct 17, 2017
@nickvergessen nickvergessen added this to the 3.0.1 (Nextcloud 13.0.1/2) milestone Nov 14, 2017
@nickvergessen nickvergessen modified the milestones: 3.0 (Nextcloud 13.0.0), 3.1 (Nextcloud 13.0.2/3) Jan 8, 2018
@nickvergessen nickvergessen modified the milestones: 3.2 (Nextcloud 13.0.2), 3.3 (Nextcloud 13.0.3/4) May 3, 2018
@nickvergessen nickvergessen modified the milestones: 5.0.0, 💚 Next Major Dec 7, 2018
@nickvergessen
Copy link
Member

Increased priority as data channels are not supported in Edge 😢

@fancycode
Copy link
Member Author

We could use the inCall flags to signal this information. They already contain bits for audio and video.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop feature: WebRTC 🚡 WebRTC connection between browsers and/or mobile clients standardisation technical debt
Projects
None yet
Development

No branches or pull requests

3 participants