Skip to content

Nick for avatar is distributed through datachannel #991

@fancycode

Description

@fancycode
Member

The nickname that is shown below the avatar is currently distributed through the datachannel by sending a nickChanged event to the status channel.

This is done once at call establishment and whenever the (guest) user changes the name.

We should change this to use the name from the participant list. This avoids having different places where the name of a user is stored / updated and allows removing the workaround for the MCU that periodically updates the name through the DataChannel (see #398).

@Ivansss adding this as issue so what we discussed doesn't get lost

Activity

nickvergessen

nickvergessen commented on Jun 22, 2018

@nickvergessen
Member

since we now store the guest name in the DB, I guess that should work fine

Ivansss

Ivansss commented on Jun 22, 2018

@Ivansss
Member

Also display names for logged-in users should be retrieved from there.
So we no longer need peer.nick for users' display name.

nickvergessen

nickvergessen commented on Mar 21, 2019

@nickvergessen
Member

This should be a subset of #397 as we need to get rid of datachannels anyway

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @nickvergessen@fancycode@Ivansss

        Issue actions

          Nick for avatar is distributed through datachannel · Issue #991 · nextcloud/spreed