Localization changes (Minor)

[mpivchev]

This removes all unused localization strings and adds periods to many sentences.

[mpivchev]

@rakekniven would you mind checking this? Thanks :)

[rakekniven]

Hello @mpivchev ,

When I look through this PR, I can't believe that there are so many unused strings. Is that really the case?
If so, the translators have done so much useless work over the last few years.
This is bad and not in the interest of the many volunteer translators on Transifex.
Thank you for cleaning up.

Regarding periods at the end of sentences:
There is no global rule in the Nextcloud project for when a period is placed at the end of a sentence and when it is not.
On what basis did you make the changes here?
I ask because this invalidates many translations. We currently have more than 50 languages that have a translation rate of more than 50% of the ios app, which means that placing a period in a string invalidates 50 strings.
I'm not sure whether the benefits justify the effort.
My vote would be to not change these strings and define the rules first.

[rakekniven]

See my comment regarding the changes to add a dot at the end of a sentence.

[mpivchev]

On what basis did you make the changes here?

Generally for longer sentences it's good to have periods at the end. It's more professional IMO.

We currently have more than 50 languages that have a translation rate of more than 50% of the ios app, which means that placing a period in a string invalidates 50 strings.

But aren't minor adjustments generally acceptable? Personally I can also update the periods for the sentences in all other languages in the project iself.

Generally I would prefer to keep the periods, but if it can cause big issues then we can omit them. What do you think?

I will also update some strings that need more major changes (bad grammar, broken english, unclear etc.) and for those what do you suggest? Do I create completely new keys for them or reuse the old keys?

Here is an example of some of those more major changes:

[rakekniven]

Generally for longer sentences it's good to have periods at the end

IMO the project needs a rule for it. We have that discussion for years.

Personally I can also update the periods for the sentences in all other languages in the project iself.

Yes. That is doable.
And are you sure that all languages use a period at the end of the sentence?
Please be aware of all RTL languages.

Generally I would prefer to keep the periods, but if it can cause big issues then we can omit them. What do you think?

See my arguments at my first post.

I will also update some strings that need more major changes (bad grammar, broken english, unclear etc.) and for those > what do you suggest? Do I create completely new keys for them or reuse the old keys?

Personally, I am very happy about improvements. Please do not use new keys and use the existing ones. Then the suggestions will remain available.

[rakekniven]

Hi! Could you please confirm that changing the strings manually to have periods at the end for all languages will be ok and won’t break anything in transifex? I would like to make sure before starting as it will take some time :)

I cannot answer this as mentioned before as I do not speak/write asian/african/arabian and many other languages.

Regarding periods at the end of sentences:
There is no global rule in the Nextcloud project for when a period is placed at the end of a sentence and when it is not.
...
My vote would be to not change these strings and define the rules first.

Still my vote.

[mpivchev]

I cannot answer this as mentioned before as I do not speak/write asian/african/arabian and many other languages.

By "break something" I meant something in Transifex itself. Say, it notifies people of changes that must be made to periods even if the periods are already added manually. Personally I've only ever changed/added the default en strings in the iOS app, so I'm not sure what happens if I change a string from the other languages.

As a middle-ground would it be ok to keep the periods for English only, as that is (I assume) the most used language, and not add them to the other languages?

Still my vote.

I know periods may be trivial but IMO it gives a more presentable and professional look for the app if big sentences have proper punctuation. As an example, all iOS strings in 1st party Apple apps that I have seen have periods at the end.

[rakekniven]

Say, it notifies people of changes that must be made to periods even if the periods are already added manually

By default the translators will not get a notification if translation strings change.
But as soon as the source strings are changed (resource change) a notification is triggered (if translator subscribed).

I know periods may be trivial but IMO it gives a more presentable and professional look for the app if big sentences have proper > punctuation. As an example, all iOS strings in 1st party Apple apps that I have seen have periods at the end.

I don't doubt that at all. But I repeat myself, see above.