[WP #60683]display error if oidc apps not supported #768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nabim777
force-pushed
the
show-error-if-not-support
branch
4 times, most recently
from
63061d9 to
f704008
Compare
nabim777
force-pushed
the
show-error-if-not-support
branch
from
2f23080 to
c8d6120
Compare
individual-it
requested changes
Feb 18, 2025
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
nabim777
force-pushed
the
show-error-if-not-support
branch
2 times, most recently
from
3fb69cb to
2b7cbcc
Compare
nabim777
force-pushed
the
show-error-if-not-support
branch
from
1c72574 to
7651acb
Compare
individual-it
requested changes
Mar 3, 2025
src/components/AdminSettings.vue
Outdated
| @@ -86,11 +86,15 @@ | |||
| <NcCheckboxRadioSwitch class="radio-check" | |||
| :checked.sync="authorizationMethod.authorizationMethodSet" | |||
| :value="authMethods.OIDC" | |||
| :disabled="!isOIDCAppInstalledAndEnabled" | |||
| :disabled="!isOIDCAppInstalledAndEnabled || !state.user_oidc_supported" | |||
There was a problem hiding this comment.
for state.user_oidc_enabled we have a function isOIDCAppInstalledAndEnabled, so we should be consequent and also have one for state.user_oidc_supported and not using it directly
There was a problem hiding this comment.
Okay @individual-it I will do that
src/components/AdminSettings.vue
Outdated
| <ErrorNote | ||
| v-if="isOIDCAppInstalledAndEnabled && !state.user_oidc_supported" | ||
| :error-title="messagesFmt.appNotSupported('user_oidc')" | ||
| :error-message="messagesFmt.minimumVersionRequired(state.user_oidc_minimum_version)" |
There was a problem hiding this comment.
use getters for the states as we do everywhere else
There was a problem hiding this comment.
Okay I will follow that
nabim777
force-pushed
the
show-error-if-not-support
branch
from
415717b to
2937663
Compare
saw-jan
reviewed
Mar 4, 2025
nabim777
force-pushed
the
show-error-if-not-support
branch
from
2937663 to
1cd4a5c
Compare
nabim777
force-pushed
the
show-error-if-not-support
branch
2 times, most recently
from
5f5fd38 to
d46c883
Compare
nabim777
force-pushed
the
show-error-if-not-support
branch
2 times, most recently
from
031f85f to
a7132b0
Compare
individual-it
requested changes
Mar 5, 2025
nabim777
force-pushed
the
show-error-if-not-support
branch
from
a7132b0 to
fc55ba1
Compare
nabim777
force-pushed
the
show-error-if-not-support
branch
from
fc55ba1 to
80be515
Compare
Signed-off-by: nabim777 <[email protected]>
Signed-off-by: nabim777 <[email protected]>
Signed-off-by: nabim777 <[email protected]>
Signed-off-by: nabim777 <[email protected]>
Signed-off-by: nabim777 <[email protected]>
nabim777
force-pushed
the
show-error-if-not-support
branch
from
80be515 to
23e8a9e
Compare
PHP Code CoverageCoverage after merging show-error-if-not-support into master will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
individual-it
approved these changes
Mar 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR, an error message is added which will display if the
user_OIDCapp is not supported with the integration OpenProject.Related Issue or Workpackage
Screenshots (if appropriate):
Types of changes
Checklist:
CHANGELOG.mdfile