Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Height for Resolve Conflicts Dialog #7815

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alexknop
Copy link

@alexknop alexknop commented Jan 31, 2025

Problem:

-With multiple conflicts to fix, sometimes the dialog box would expand beyond the screen in height and could not be resized to a smaller height.

Solution:

-Adjusted height based on content
-Set more reasonable minimum height

Fixes #7785 #6228

Screenshot From 2025-01-31 12-04-14
Screenshot From 2025-01-31 12-12-53

Copy link
Collaborator

@claucambra claucambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! I have one comment

src/gui/ResolveConflictsDialog.qml Outdated Show resolved Hide resolved
@alexknop alexknop force-pushed the conflictdialogfix branch 2 times, most recently from 3a082e0 to 328338c Compare February 3, 2025 14:22
@alexknop
Copy link
Author

alexknop commented Feb 3, 2025

@claucambra Done. Thank you

Signed-off-by: knopalex <[email protected]>
Copy link
Collaborator

@claucambra claucambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Window for solving synchronization conflicts is oversized
3 participants