Check for yarn #56
Open
Check for yarn #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
added 2 commits
January 22, 2021 08:36
cade-conklin
suggested changes
May 17, 2022
tasks/node/env/dependencies.go
Outdated
Comment on lines
37
to
54
| // var packageManager string | ||
| // if upstream["Node/Env/NpmVersion"].Status == tasks.Info { | ||
| // packageManager = "npm" | ||
| // } | ||
|
|
||
| // if packageManager == "" { | ||
| // if upstream["Node/Env/YarnVersion"].Status == tasks.Info { | ||
| // packageManager = "yarn" | ||
| // } | ||
| // } | ||
|
|
||
| // if packageManager == "" { | ||
| // return tasks.Result{ | ||
| // Status: tasks.None, //tasks.Warning? | ||
| // Summary: "This task did not because we could not found npm or yarn installed", | ||
| // } | ||
| // } | ||
|
|
There was a problem hiding this comment.
If these aren't needed, the comments can be deleted
|
@punkael would you mind pulling in the latest changes from |
|
I updated the yarn task to use dependency injection and added tests |
|
Updated the dependencies task to check for yarn if npm isn't installed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Goals
Implementation Details
How to Test