Skip to content

Update langchain #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 21, 2025
Merged

Conversation

TristanLecourtois
Copy link
Contributor

Purpose

  • Ensure compatibility with the latest version of LangChain.
  • Fix a bug in ros2_topic_list, ros2_service_list and ros2_node_list where the pattern parameter was not typed as optional, which caused a test failure.

Proposed Changes

  • [CHANGE] Updated LangChain version in the project dependencies.
  • [FIX] Modified ros2_topic_list to correctly type pattern as Optional[str] instead of str.
  • [FIX] Updated the related test

Issues

  • Related to internal compatibility issues with updated LangChain versions.
  • No external GitHub issue linked.

Testing

  • Ran pytest on all test files.
  • All tests passed or skipped correctly.

@RobRoyce
Copy link
Collaborator

Thank you @TristanLecourtois. This should resolve #61. I'll merge in after running workflows.

@RobRoyce RobRoyce merged commit 73917d3 into nasa-jpl:main Apr 21, 2025
2 checks passed
@RobRoyce RobRoyce mentioned this pull request Apr 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants