Skip to content

perf(core): Introduce backend performance benchmarking #9199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 91 commits into from
Closed
Changes from 1 commit
Commits
Show all changes
91 commits
Select commit Hold shift + click to select a range
772dd09
Initial setup
ivov Apr 9, 2024
762754b
Add CI action
ivov Apr 9, 2024
c6d07e8
Refactor into `packages/cli/src/benchmark`
ivov Apr 9, 2024
1a6045a
Add start cmd
ivov Apr 9, 2024
b0832cb
Fix script ref
ivov Apr 9, 2024
a1e19fb
Init and run start cmd
ivov Apr 9, 2024
c974ec2
Update lockfile
ivov Apr 10, 2024
f8127b8
Limit CI action to BE PRs
ivov Apr 10, 2024
357b539
Merge branch 'master' into codspeed-tinybench
ivov Apr 11, 2024
168ccb0
Cleanup
ivov Apr 11, 2024
24042a1
Move benchmarks inside `cli/test`
ivov Apr 11, 2024
cd99c6e
Add `ts-ignore` to allow `test` to compile
ivov Apr 11, 2024
7e35897
Cleanup
ivov Apr 11, 2024
4414eee
Set up test n8n dir
ivov Apr 11, 2024
98df748
Reload constants
ivov Apr 11, 2024
155ff50
Suite class
ivov Apr 11, 2024
1d1a6ec
Comment out constants reload
ivov Apr 11, 2024
ff2d09c
Create BenchmarkSetup
ivov Apr 11, 2024
f4e76d6
Remove unused `init.ts`
ivov Apr 11, 2024
2382e65
Restructuring
ivov Apr 11, 2024
43c02be
Merge branch 'master' into codspeed-tinybench
ivov Apr 11, 2024
648d5b8
refactor(core): Fix type errors in BE tests (no-changelog)
ivov Apr 11, 2024
3f38f88
Simplify
ivov Apr 11, 2024
9e7911a
Back to cli/src
ivov Apr 19, 2024
0c39b4f
Remove logging noise
ivov Apr 19, 2024
a193bd3
Make naming consistent
ivov Apr 19, 2024
42b67ec
Implement `beforeEach``
ivov Apr 19, 2024
6dcb2e5
Move to suites.ts
ivov Apr 19, 2024
8775968
Cleanup
ivov Apr 19, 2024
a6bd9ea
More cleanup
ivov Apr 19, 2024
8282963
Organize
ivov Apr 19, 2024
d24f412
Prevent duplicate `beforeEach``
ivov Apr 19, 2024
8a0f64b
Implement `afterEach`
ivov Apr 19, 2024
fe4ce3c
Cleanup
ivov Apr 19, 2024
e2bc37b
Merge branch 'master' into codspeed-tinybench
ivov Apr 22, 2024
86562de
Reduce diff
ivov Apr 22, 2024
116b92d
Fixtures setup
ivov Apr 22, 2024
7bb25ca
Pick up fixtures
ivov Apr 22, 2024
c42016d
First benchmark
ivov Apr 22, 2024
093e75c
Phrasing
ivov Apr 23, 2024
3c36304
Cleanup
ivov Apr 23, 2024
169c627
Typo
ivov Apr 23, 2024
ae6ff9b
Add comment
ivov Apr 23, 2024
d776bbe
Add question
ivov Apr 23, 2024
403b466
Add second benchmark
ivov Apr 23, 2024
b8c6b62
Naming
ivov Apr 23, 2024
497966f
Add TODO
ivov Apr 23, 2024
20069b5
Add clarification
ivov Apr 23, 2024
facdac5
Third benchmark
ivov Apr 23, 2024
4157807
Simplify paths
ivov Apr 23, 2024
82b3f78
Introduce `describe()`
ivov Apr 23, 2024
421f23b
Prevent duplicate suites
ivov Apr 23, 2024
b12d254
`describe` -> `suite`
ivov Apr 23, 2024
57724d5
Script to document suites
ivov Apr 23, 2024
d6d7efb
Cleanup
ivov Apr 23, 2024
d0be040
Cleanup
ivov Apr 24, 2024
8694d62
Account for no workflow referred to
ivov Apr 24, 2024
2bb4f63
Docs
ivov Apr 24, 2024
dcbd2b7
Disambiguate
ivov Apr 24, 2024
fa9f59f
Clarification
ivov Apr 24, 2024
156a054
Stop benchmarks on error
ivov Apr 24, 2024
133a2b1
Try 127.0.0.1
ivov Apr 25, 2024
ff53c57
`client` -> `agent`
ivov Apr 26, 2024
ea2cc83
Deduplicate repository logic
ivov Apr 26, 2024
26c8e81
Simplify setup and teardown
ivov Apr 26, 2024
54f5463
`registration` -> `api`
ivov Apr 26, 2024
7a4be56
Make bench values configurable
ivov Apr 26, 2024
02f4809
Remove commented out start code
ivov Apr 26, 2024
280caae
Remove outdated comment
ivov Apr 26, 2024
c8bf11b
Typo
ivov Apr 26, 2024
b61f8c1
Better solution for `InstanceSettings` user home dir
ivov Apr 26, 2024
def86d2
Comment out unneeded steps
ivov Apr 26, 2024
d94d312
Remove outdated comment
ivov Apr 26, 2024
732b358
Restore steps
ivov Apr 26, 2024
3bef94c
Add TODO
ivov Apr 26, 2024
dfbab14
Cleanup
ivov Apr 26, 2024
f8cbdd8
More cleanup
ivov Apr 26, 2024
d607d70
Add display
ivov Apr 27, 2024
471470a
Simplify logging
ivov Apr 27, 2024
526bb83
Document
ivov Apr 28, 2024
e443f6e
Merge branch 'master' into codspeed-tinybench
ivov Apr 30, 2024
57bcc87
perf(core): Support Postgres in benchmarks (#9246)
ivov Apr 30, 2024
4ef5a2a
Improve docs
ivov Apr 30, 2024
1a91102
Handle connection error gracefully
ivov Apr 30, 2024
00ff0b3
Remove outdated comment
ivov Apr 30, 2024
eaa8790
Remove another TODO
ivov Apr 30, 2024
c1d69e8
Reduce diff
ivov Apr 30, 2024
f60caf4
Cleanup
ivov Apr 30, 2024
b40652d
Patch @codspeed/[email protected]
ivov Apr 30, 2024
05ed548
Cleanup
ivov May 2, 2024
bf14a70
Merge branch 'master' into codspeed-tinybench
ivov May 3, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove outdated comment
  • Loading branch information
ivov committed Apr 26, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
commit d94d312374853f6de2ec0bfbe96720729e66b56a
2 changes: 1 addition & 1 deletion packages/core/src/InstanceSettings.ts
Original file line number Diff line number Diff line change
@@ -21,7 +21,7 @@ export class InstanceSettings {
private readonly userHome = this.getUserHome();

/** The path to the n8n folder in which all n8n related data gets saved */
readonly n8nFolder = path.join(this.userHome, '.n8n'); // @TODO: Solution that keeps this readonly
readonly n8nFolder = path.join(this.userHome, '.n8n');

/** The path to the folder where all generated static assets are copied to */
readonly staticCacheDir = path.join(this.userHome, '.cache/n8n/public');