ci: Reuse common build actions and fix turbo outputs (no-changelog) #15830
+139
−191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we don't run the tests we don't generate coverage report. Also used existing action for setup/build
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
cubic reviewed 2 files and found no issues. Review PR in cubic.dev.
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
shortstacked
force-pushed
the
CAT-865-ensure-codecov-upload
branch
15 times, most recently
from
23f5a21 to
a917c77
Compare
shortstacked
changed the title
shortstacked
requested review from
a team and
netroy
and removed request for
a team
shortstacked
force-pushed
the
CAT-865-ensure-codecov-upload
branch
from
a917c77 to
c9ece35
Compare
ivov
reviewed
May 30, 2025
ivov
previously approved these changes
May 30, 2025
Workflow Test Results 📊 🔴 1 Failed,
|
| Workflow ID | Workflow Name | Reason |
|---|---|---|
| 237 | BasicLLMChain:AzureChat | Workflow contains 1 deleted data. |
⚠️ Warnings (2)
| Workflow ID | Workflow Name | Reason |
|---|---|---|
| 53 | ConvertKit:CustomField:create getAll update delete... | Workflow contains new data that previously did not exist. |
| 257 | Agent:auto-fix:anthropic | Workflow contains new data that previously did not exist. |
|
✅ All Cypress E2E specs passed |
shortstacked
force-pushed
the
CAT-865-ensure-codecov-upload
branch
from
0f4d68b to
a94b4a8
Compare
shortstacked
force-pushed
the
CAT-865-ensure-codecov-upload
branch
from
7c582f2 to
b417366
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reuse build action for setup/install/build/cache across multiple jobs.
Fix outputs for Turbo cache code coverage reports.
Summary
Turbo wasn't restoring the test results or code coverage files when it was restored from cache, leading to missing reports in CodeCov.
Reused setup action across multiple jobs.
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/CAT-865/ci-ensure-codecov-results-are-uploaded
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)