[DataGrid] Improve test coverage of server side data source (@MBilalShafi) #15988
+515
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
added
cherry-pick
|
Deploy preview: https://deploy-preview-15988--material-ui-x.netlify.app/ |
|
@MBilalShafi Should we update and merge this PR? |
arminmeh
approved these changes
Jan 24, 2025
packages/x-data-grid-pro/src/tests/dataSource.DataGridPro.test.tsx
Outdated
Show resolved
Hide resolved
| await waitFor(() => { | ||
| expect(fetchRowsSpy.callCount).to.equal(1); | ||
| }); | ||
| act(() => { |
There was a problem hiding this comment.
I will try to update these with cherry pick from #16101
Once the spy is kept between re-renders we can use setProps and get rid of the act here
packages/x-data-grid-pro/src/tests/dataSourceTreeData.DataGridPro.test.tsx
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #15942
Also added a few changes done in #15769