-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix aria2 build #23257
base: master
Are you sure you want to change the base?
fix aria2 build #23257
Conversation
No need to run `autoreconf -ifv || autoreconf -ifv`, which will break check of gettext version macros
I'm wondering if it is possible to use shared package
So I would appreciate it if anyone tells me about why |
We need autoreconf for clang builds to work, the DLL is missing now without it. I'm not sure about the gettext error, needs investigating.
yes, but both cases are broken since you can't hardcode a Windows path in the build, users have MSYS2 installed in different locations. Does aria have some way to ask openssl by default? That would support path relocation. |
I removed autoreconf commands because it can't build on my Windows machine (nor could Github CI), which raise an error when checking gettext macro version.
This error should be easily reproduced through an rebuild of the package, or more exactly, run
Sorry but I don't agree with this. What I hardcoded at build time is a Cygwin path, which is relative to MSYS2 installation. The issue is that their build configure doesn't support Cygwin path, while runtime argument supports. This really confuses me when trying to share certificates from /usr. |
ca-certificates
for HTTPS(SSL) dependency
also fix: add
ca-certificates
for HTTPS(SSL) dependency