Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix aria2 build #23257

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

fix aria2 build #23257

wants to merge 4 commits into from

Conversation

zent1n0
Copy link

@zent1n0 zent1n0 commented Feb 1, 2025

also fix: add ca-certificates for HTTPS(SSL) dependency

@zent1n0
Copy link
Author

zent1n0 commented Feb 2, 2025

I'm wondering if it is possible to use shared package ca-certificates for SSL certs.
It runs successful when passing argument --ca-certificate=/usr/ssl/cert.pem, but configure with --with-ca-bundle="/usr/ssl/cert.pem" will result in [ERROR] Failed to load trusted CA certificates from /usr/ssl/cert.pem. Cause: error:80000003:system library::No such process. I believe it is related to file path convertion, as the configuration could compile and run on my ArchLinux machine.

I'm wondering if it is possible to use shared package ca-certificates for SSL certs.

So I would appreciate it if anyone tells me about why ca-certificates locates in /usr/ instead of /etc/, or it's possible to move these architecture-independent files into shared normal places /etc/.

@lazka
Copy link
Member

lazka commented Feb 6, 2025

We need autoreconf for clang builds to work, the DLL is missing now without it. I'm not sure about the gettext error, needs investigating.

I believe it is related to file path convertion, as the configuration could compile and run on my ArchLinux machine.

yes, but both cases are broken since you can't hardcode a Windows path in the build, users have MSYS2 installed in different locations.

Does aria have some way to ask openssl by default? That would support path relocation.

@zent1n0
Copy link
Author

zent1n0 commented Feb 9, 2025

We need autoreconf for clang builds to work, the DLL is missing now without it.

I removed autoreconf commands because it can't build on my Windows machine (nor could Github CI), which raise an error when checking gettext macro version.

I'm not sure about the gettext error, needs investigating.

This error should be easily reproduced through an rebuild of the package, or more exactly, run autoreconf -i on any system not bundled with gettext 18.0, as version macro was defined with aria2 release 1.73.0.
On Arch there's no autoreconf preparation, so I just removed it to give a quick fix for CI. Maybe you can provide a better solution to fix the build issue.

yes, but both cases are broken since you can't hardcode a Windows path in the build, users have MSYS2 installed in different locations.

Sorry but I don't agree with this. What I hardcoded at build time is a Cygwin path, which is relative to MSYS2 installation. The issue is that their build configure doesn't support Cygwin path, while runtime argument supports. This really confuses me when trying to share certificates from /usr.
BTW it's not the critical problem. The true issue is this package is unable to be built now.

@zent1n0 zent1n0 changed the title fix: add ca-certificates for HTTPS(SSL) dependency fix aria2 build Feb 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants