Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libpng: Update to 1.6.45 #23046

Merged
merged 1 commit into from
Jan 13, 2025
Merged

libpng: Update to 1.6.45 #23046

merged 1 commit into from
Jan 13, 2025

Conversation

lazka
Copy link
Member

@lazka lazka commented Jan 9, 2025

And try dropping the apng patches

* Arch dropped them long ago
* Gentoo is working on it

(see the removed comment for links)

@lazka
Copy link
Member Author

lazka commented Jan 9, 2025

This would affect python-imagecodecs (removed apng support). @kmilos any thoughts/objections?

@kmilos
Copy link
Contributor

kmilos commented Jan 9, 2025

We'll just have to patch out support for it in imagecodecs then, and ask upstream to disable it in the future.

@lazka
Copy link
Member Author

lazka commented Jan 9, 2025

Oh, I thought it's optional already there, since not every distro has it. Let me try.

@kmilos
Copy link
Contributor

kmilos commented Jan 9, 2025

Just needs del EXTENSIONS['apng'] in customize_build_mingw() of setup.py...

@cgohlke Can we please disable this for MinGW in future versions?

@cgohlke
Copy link

cgohlke commented Jan 10, 2025

Can we please disable this for MinGW in future versions?

Sure, your loss.

@lazka lazka changed the title libpng: Update to 1.6.45; drop apng patches libpng: Update to 1.6.45 Jan 13, 2025
@lazka lazka marked this pull request as ready for review January 13, 2025 20:30
@lazka
Copy link
Member Author

lazka commented Jan 13, 2025

So, turns out the apng patches were released in a timely fashion this time around, so might as well continue using them for now.

I'll keep the comments here in mind for future updates, thanks everyone.

@lazka lazka merged commit 8b30d1c into msys2:master Jan 13, 2025
7 checks passed
@kmilos
Copy link
Contributor

kmilos commented Jan 15, 2025

@cgohlke Please disregard the request for now, and apologies for the noise. We should probably switch to managing the features locally via imagecodecs_distributor_setup...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants