Skip to content

Texture: Add setValues. #31087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 15, 2025
Merged

Conversation

CodyJasonBennett
Copy link
Contributor

@CodyJasonBennett CodyJasonBennett commented May 12, 2025

Fixed #28100

Description

Implements setValues in Texture. Since every render target class would need to filter options into texture parameters, I implement an internal _setTextureOptions method. It is recommended to use public API to enjoy validation.

Copy link

github-actions bot commented May 12, 2025

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 337.26
78.64
337.26
78.64
+0 B
+0 B
WebGPU 549.52
152.34
549.52
152.34
+0 B
+0 B
WebGPU Nodes 548.87
152.18
548.87
152.18
+0 B
+0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 467.34
112.95
468.12
113.14
+777 B
+190 B
WebGPU 624.43
169.06
625.21
169.25
+777 B
+193 B
WebGPU Nodes 579.28
158.35
580.06
158.54
+777 B
+191 B

@Mugen87 Mugen87 added this to the r177 milestone May 14, 2025
@Mugen87
Copy link
Collaborator

Mugen87 commented May 14, 2025

@gkjohnson Does the PR look good to you as well?

@Mugen87 Mugen87 merged commit 7703433 into mrdoob:dev May 15, 2025
12 checks passed
@CodyJasonBennett CodyJasonBennett deleted the texture-setvalues branch May 15, 2025 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WebGLArrayRenderTarget: Constructor texture options are not respected
3 participants