Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update font to Mozilla Type Family (Fixes #63) #67

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Conversation

alexgibson
Copy link
Member

This PR updates the consent banner to use the same font-stack as we're using in bedrock on refresh pages.

I added some @font-face() rules to the demo page so that you can preview the new font when installed locally (I tested using the OTF format).

We'll likely need to overwrite these font styles in bedrock depending on the page (new / old), but this should be the new default going forward.

@alexgibson
Copy link
Member Author

Note for reviewer: you might need to test in a browser with ETP (enhanced tracking protection) disabled to preview locally installed fonts using localhost.

Copy link

@maureenlholland maureenlholland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Falls back to Helvetica Neue with ETP on
Screenshot 2025-01-09 at 12 37 40 PM

Shows local Mozilla with ETP off
Screenshot 2025-01-09 at 12 38 07 PM

@alexgibson alexgibson merged commit 1f971c2 into main Jan 10, 2025
1 check passed
@alexgibson alexgibson deleted the update-font branch January 10, 2025 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants