Skip to content

fix(dev-server-esbuild): properly parse tsconfig files from the provided path using get-tsconfig, default tsconfig path to tsconfig.json if ts or tsx is true in config #2972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix(dev-server-esbuild): properly parse tsconfig files from the provided path using get-tsconfig, default tsconfig path to tsconfig.json if ts or tsx is true in config #2972

wants to merge 3 commits into from

Conversation

anthony-y-zhu14
Copy link

What I did

  1. fix [@web/dev-server-esbuild] does not read tsconfig.json #1921 by coping the changes @peschee had done in Plugin does not resolve extends in tsconfig.json dev-server-esbuild#20 to the dev-server-esbuild package in web monorepo (not clear why theres two copy of the same package)
  2. default tsconfig path to "tsconfig.json" if tsconfig path is not specified in config but either ts or tsx is set to true (addressing this comment [@web/dev-server-esbuild] does not read tsconfig.json #1921 (comment))

Anthony Y. Zhu and others added 2 commits July 25, 2025 23:21
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jul 26, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 6b01b33

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@web/dev-server-esbuild Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@anthony-y-zhu14 anthony-y-zhu14 changed the title properly parse tsconfig files from the provided path using get-tsconfig, default tsconfig path to tsconfig.json if ts or tsx is true in config fix: properly parse tsconfig files from the provided path using get-tsconfig, default tsconfig path to tsconfig.json if ts or tsx is true in config Jul 26, 2025
@anthony-y-zhu14 anthony-y-zhu14 changed the title fix: properly parse tsconfig files from the provided path using get-tsconfig, default tsconfig path to tsconfig.json if ts or tsx is true in config fix(dev-server-esbuild): properly parse tsconfig files from the provided path using get-tsconfig, default tsconfig path to tsconfig.json if ts or tsx is true in config Jul 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[@web/dev-server-esbuild] does not read tsconfig.json
1 participant
@anthony-y-zhu14