Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libshout] New port of icecast-libshout #43108

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

JoergAtGithub
Copy link
Contributor

  • Changes comply with the maintainer guide.
  • The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
  • Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx.
  • The versioning scheme in vcpkg.json matches what upstream says.
  • The license declaration in vcpkg.json matches what upstream says.
  • The installed as the "copyright" file matches what upstream says.
  • The source code of the component installed comes from an authoritative source.
  • The generated "usage text" is accurate. See adding-usage for context.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is in the new port's versions file.
  • Only one version is added to each modified port's versions file.

@JoergAtGithub JoergAtGithub changed the title New port libshout [libshout] New port of icecast-libshout Jan 5, 2025
@WangWeiLin-MV WangWeiLin-MV added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Jan 6, 2025
@JoergAtGithub JoergAtGithub force-pushed the libshout branch 2 times, most recently from 72c08ea to d73015b Compare January 18, 2025 14:50
@JoergAtGithub
Copy link
Contributor Author

I would appreciate some help with the Windows builds. The autoconf seems to go wrong somehow.
What I can see from the logs is, that it lists a non existing filename ssl.lib instead of libssl.lib for OpenSSL integration.

@WangWeiLin-MV
Copy link
Contributor

WangWeiLin-MV commented Jan 20, 2025

It is passed in Linux. Testing in Windows.

Updates: openssl:openssl_x64-windows provides libssl.lib

@JoergAtGithub JoergAtGithub marked this pull request as ready for review February 2, 2025 01:11
@JoergAtGithub
Copy link
Contributor Author

@WangWeiLin-MV I set the Windows triplets as unsupported by this port, as I found no solution for the build fails.
All other triplets should work as indended!

"speex"
],
"features": {
"speex": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can see, this feature is not 'wired up' in portfile.cmake. Should it be here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I see, it goes through https://gitlab.xiph.org/xiph/icecast-libshout/-/blob/master/configure.ac#L183 -- this needs to be fixed to respect the feature.

}
],
"default-features": [
"speex"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've kind of taken a dim view of our default-features feature over time, as users find it very difficult to disable anything declared as a default feature.

Moreover, this default feature appears to enable APIs, which is a problem because things become silently broken. See https://learn.microsoft.com/vcpkg/contributing/maintainer-guide#default-features-should-enable-behaviors-not-apis

Can this just not be a feature in the first place if you expect people to ~always need it, or is speex painful to build?

ports/libshout/portfile.cmake Outdated Show resolved Hide resolved
ports/libshout/portfile.cmake Outdated Show resolved Hide resolved
ports/libshout/portfile.cmake Outdated Show resolved Hide resolved
ports/libshout/portfile.cmake Outdated Show resolved Hide resolved
ports/libshout/vcpkg.json Outdated Show resolved Hide resolved
REPO xiph/icecast-common
REF 5de3e8b3b063002d8a9f52122e97f721e1742531
HEAD_REF master
SHA512 eb505b9019a97a91e10fa505225dde4f9950f6ae50b54c7afd806f6eebeb865862de85e9d0a114f2e8c4f974c4db60622e71f52f5e758cdb0efcda735bb7ab51
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
SHA512 eb505b9019a97a91e10fa505225dde4f9950f6ae50b54c7afd806f6eebeb865862de85e9d0a114f2e8c4f974c4db60622e71f52f5e758cdb0efcda735bb7ab51
SHA512 f064e2b2dd686c7647ba4c5afb9ca7e85b2015643d7a185cc319f47461aacc765e7f9b3e9576e09a73a8af0724a54fafdd7c064756d3c6e97329bb5f77806933

REPO xiph/icecast-m4
REF 57027c6cc3f8b26d59e9560b4ac72a1a06d643b9
HEAD_REF master
SHA512 d2a9507a5a0d36134c4dc37fe38b3cb4d954dee3ffa5fd2b1bb4cd8af1e7804248e234e55fbcfba20fecec4bf159b2616d14ac537d03ffbff095a02d5f4bf201
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
SHA512 d2a9507a5a0d36134c4dc37fe38b3cb4d954dee3ffa5fd2b1bb4cd8af1e7804248e234e55fbcfba20fecec4bf159b2616d14ac537d03ffbff095a02d5f4bf201
SHA512 67fe6fad8bf86990b5da311d729b9a746849f3d920c018112b4625b5e0d37a85444be16367967cb18a871c1ca1d679f5924ad3fc8547fbb30746b7e1f4b396bc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants