-
Notifications
You must be signed in to change notification settings - Fork 173
Upgrades dependencies to latest + changes required to support latest versions #265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrades dependencies to latest + changes required to support latest versions #265
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 24 out of 26 changed files in this pull request and generated no comments.
Files not reviewed (2)
- .eslintrc.yml: Language not supported
- package.json: Language not supported
…for each supported nodejs version
…l-lib-report. Else, it takes an old one and things break.
@Xapphire13 This is just an idea of upgrading the dependencies and removing support for older NodeJS versions. I don't think I would merge it now, but if we move towards a new major version, maybe this is part of this new version? Let me know your thoughts and I can also start preparing some ideas for this next major version. |
I think this would be a major version upgrade. There's a risk of breaking changes with older TS versions. @Xapphire13 and I discussed this a few years back and I recall we decided that if we did get to doing full TS5 support we'd up the major version. |
I agree. I think it's worth planning this properly. Then, what I think I can do, is not to merge this on master but merge this in a 5.x.x branch so we can see how this project could evolve and then decide if it makes sense or not to continue. |
Here's a list of things this PR does:
Not sure if you want to merge it now, but this gives us an idea of what needs to happen to update the dependencies. I feel like updating the dev dependencies is useful.
However, this also updates
tslib
and I need to understand better what the implications of doing that are. Does that mean we should do amajor
upgrade? If yes, then I can start planning about features we would want to include if we decide to go down that route.