initial implementation of macOS crypto backend #1453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gdams
force-pushed
the
dev/gadams/darwincrypto
branch
7 times, most recently
from
daa02a7 to
f092c70
Compare
gdams
force-pushed
the
dev/gadams/darwincrypto
branch
16 times, most recently
from
2f2b6d7 to
c9eda5b
Compare
|
Filed actions/runner-images#11331 about the GOROOT workaround on macOS. |
|
Now, test failures. |
gdams
force-pushed
the
dev/gadams/darwincrypto
branch
5 times, most recently
from
d45bb85 to
2dfa2d3
Compare
gdams
force-pushed
the
dev/gadams/darwincrypto
branch
7 times, most recently
from
ace4c75 to
b09d530
Compare
gdams
force-pushed
the
dev/gadams/darwincrypto
branch
4 times, most recently
from
5c2f434 to
8398498
Compare
gdams
force-pushed
the
dev/gadams/darwincrypto
branch
2 times, most recently
from
f3faaea to
24f3783
Compare
gdams
force-pushed
the
dev/gadams/darwincrypto
branch
from
24f3783 to
389f4b1
Compare
qmuntal
requested changes
Jan 15, 2025
gdams
commented
Jan 15, 2025
| - { os: darwin, arch: amd64, config: test } | ||
| - { experiment: darwincrypto, os: darwin, arch: amd64, config: test } | ||
| - { experiment: darwincrypto, os: darwin, arch: amd64, config: test, fips: true } | ||
| # - { os: darwin, arch: arm64, config: devscript } |
There was a problem hiding this comment.
noting that I'll enable this in a follow-up PR once a new version of GoTool@0 has been released that contains microsoft/azure-pipelines-tasks#20783
gdams
force-pushed
the
dev/gadams/darwincrypto
branch
from
6a7892c to
8bcce40
Compare
mertakman
approved these changes
Jan 15, 2025
|
Turns out the GOROOT issue is AzDO-specific, in GoTool@0: microsoft/azure-pipelines-tasks#20796 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #1013