Add the detailed info for parameter 'verbose' #1435
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thinkall
reviewed
May 23, 2025
thinkall
approved these changes
May 23, 2025
added 3 commits
May 23, 2025 01:22
thinkall
requested changes
May 23, 2025
| @@ -40,7 +40,7 @@ | |||
| "xgboost>=0.90,<3.0.0", | |||
| "scipy>=1.4.1", | |||
| "pandas>=1.1.4", | |||
| "scikit-learn>=1.0.0", | |||
| "scikit-learn==1.3.1", | |||
There was a problem hiding this comment.
This is not necessary and we should not stick to any specific version.
| @@ -57,7 +57,7 @@ | |||
| "scipy>=1.4.1", | |||
| "pandas>=1.1.4,<2.0.0; python_version<'3.10'", | |||
| "pandas>=1.1.4; python_version>='3.10'", | |||
| "scikit-learn>=1.0.0", | |||
| "scikit-learn==1.3.1", | |||
There was a problem hiding this comment.
This is not necessary and we should not stick to any specific version.
| @@ -85,7 +85,7 @@ jobs: | |||
| - name: Test with pytest | |||
| if: matrix.python-version != '3.10' | |||
| run: | | |||
| pytest test/ | |||
| pytest test/ --ignore=test/automl/test_mlflow.py | |||
There was a problem hiding this comment.
We should not skip the test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Add the detailed explanation for parameter 'verbose', which can control the logger level such as ERROR, WARNING messages.
Related issue number
Related to #1428
Checks