feat(metagen): mdk_rs finalization
#673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yohe-Am
force-pushed
the
feat/mdk-rs-second-leg
branch
from
8cdef28 to
731fa3e
Compare
Yohe-Am
changed the base branch from
upload/deno-runtime
to
refactor/MET-404/wasmtime-pyrt
Yohe-Am
commented
Apr 28, 2024
3 tasks
zifeo
reviewed
Apr 28, 2024
2 tasks
Yohe-Am
force-pushed
the
refactor/MET-404/wasmtime-pyrt
branch
from
30ff471 to
93e1a7d
Compare
Yohe-Am
force-pushed
the
feat/mdk-rs-second-leg
branch
from
731fa3e to
6019011
Compare
Implements python runtime support for `import_function` materializers. This is an stacked PR on #673 which itself is appended on #687 for tackling MET-404. #### Migration notes This PR introduced a breaking change in the importer logic for python modules brought in through `pyrt.import_` and it's deps. After this PR, any path imports must be prefixed with `.`, `..`, `...` and so to point to relative path locations. This behavior is at odds with standard python which looks for relative modules and packages even if there are no dot prefixes. - [x] The change come with new or modified tests - [x] Hard-to-understand functions have explanatory comments <!-- 5. Readiness checklist - [ ] End-user documentation is updated to reflect the change -->
Yohe-Am
merged commit 3d989a6
into
refactor/MET-404/wasmtime-pyrt
6 of 11 checks passed
Yohe-Am
pushed a commit
that referenced
this pull request
May 7, 2024
fix: cherry-pick feat(wasm): wit component support test(wasm): error propagation refactor(wasm): all remaining wasmedge -> wasm fix(wasm): bad conversion feat(wasm): nested object output test(wasm): tuple deserialize test(wasm): update binding test value feat(wasm): nested wit input support feat(wasm): handle enum input, fix object bug feat(wasm): reject on extra fields fix(wasm): typos and minor cleanups fix(tests.yml): disable cache deno dir for now fix: version lock fix: lockfile refactor: rename all wasmedge ref. to wasm refactor(gate): wasi 0.2 pyrt refactor: rename to `pyrt_wit_wire` fix: pre-commit issue wip: try ci fix feat: add pyrt bin inline refactor: `python_wasi` -> `python` wip: import module support fix: rebase bugs feat(metagen): `mdk_rs` finalization (#673) - Finalizes the host side of the `wit_wire` implementation started in - Fixes a few issues with the `mdk_rust` generator. The code generator was already in place but we the typegate had no support for the `wit_wire` interface used by the rust mdk. This PR adds that. The two week delay is mainly due to the base work required in #669 and related PRs. _No breaking changes on user._ - [x] The change come with new or modified tests - [x] Hard-to-understand functions have explanatory comments - [ ] End-user documentation is updated to reflect the change feat: Enable batch prisma queries in the typegate runtime (#682) Enable batch prisma queries (and transaction) in the typegate runtime Console [MET-381](https://linear.app/metatypedev/issue/MET-381/console-collections) <!-- Explain HOW users should update their code when required --> - [x] The change come with new or modified tests - [ ] Hard-to-understand functions have explanatory comments - [ ] End-user documentation is updated to reflect the change --------- Co-authored-by: Teo Stocco <[email protected]> Co-authored-by: Yohe-Am <[email protected]> fix: update poetry lockfile fix: CI issues fix: minor bugs fix: ci breakage wip: try fix
Yohe-Am
pushed a commit
that referenced
this pull request
May 23, 2024
fix: cherry-pick feat(wasm): wit component support test(wasm): error propagation refactor(wasm): all remaining wasmedge -> wasm fix(wasm): bad conversion feat(wasm): nested object output test(wasm): tuple deserialize test(wasm): update binding test value feat(wasm): nested wit input support feat(wasm): handle enum input, fix object bug feat(wasm): reject on extra fields fix(wasm): typos and minor cleanups fix(tests.yml): disable cache deno dir for now fix: version lock fix: lockfile refactor: rename all wasmedge ref. to wasm refactor(gate): wasi 0.2 pyrt refactor: rename to `pyrt_wit_wire` fix: pre-commit issue wip: try ci fix feat: add pyrt bin inline refactor: `python_wasi` -> `python` wip: import module support fix: rebase bugs feat(metagen): `mdk_rs` finalization (#673) - Finalizes the host side of the `wit_wire` implementation started in - Fixes a few issues with the `mdk_rust` generator. The code generator was already in place but we the typegate had no support for the `wit_wire` interface used by the rust mdk. This PR adds that. The two week delay is mainly due to the base work required in #669 and related PRs. _No breaking changes on user._ - [x] The change come with new or modified tests - [x] Hard-to-understand functions have explanatory comments - [ ] End-user documentation is updated to reflect the change feat: Enable batch prisma queries in the typegate runtime (#682) Enable batch prisma queries (and transaction) in the typegate runtime Console [MET-381](https://linear.app/metatypedev/issue/MET-381/console-collections) <!-- Explain HOW users should update their code when required --> - [x] The change come with new or modified tests - [ ] Hard-to-understand functions have explanatory comments - [ ] End-user documentation is updated to reflect the change --------- Co-authored-by: Teo Stocco <[email protected]> Co-authored-by: Yohe-Am <[email protected]> fix: update poetry lockfile fix: CI issues fix: minor bugs fix: ci breakage wip: try fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wit_wireimplementation started in refactor(gate): wasi 0.2 pyrt #687 .mdk_rustgenerator.Motivation and context
The code generator was already in place but we the typegate had no support for the
wit_wireinterface used by the rust mdk. This PR adds that.The two week delay is mainly due to the base work required in #669 and related PRs.
Migration notes
No breaking changes on user.
Checklist