[WIP] MBE-1300 mirrord cli crate porting to windows #3448
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etalbear-co#3433) * wip * implemented process:resume, run process suspended and resume works * commandline parsing improvement * wip: started hooking implementation based on asdf-overlay-hook * destroy workspace cargo.toml for local windows development * hooking works, calling hooks explicitly * wip. now reading wstr argument of hooked function works * wip, some commandline improvements * wip. working injected using dll-syringe crate on dllmain of layer-win dll * wip: organize some stuff, injecting and hooking works, starting to preparing testing logic * strategy works! :) * remove unnecessary comments * wip: tests impl. * ... and the tests work * improve cmd error handling and printing usage * tests are up-to date, fixed bool check in layer-win * dont need OsString * improve commandline parsing and prints * move poc code to subdir to let other put theirs aside
* Add e2e test for passthrough mirroring and stealing (metalbear-co#3427) * Added more mirroring tests * Enable passthrough mirroring in OSS test * Fix namespace names * Clippy * Docs * HTTP1 is easier * Now it works * unwraps -> expects * Fix lingering agent (metalbear-co#3437) * Fixed TcpStealerTask exit condition * Style * Changelog * E2E test * Fix test? * Move the test to 'cleanup' module * ?? * Fix test * 3.152.1 (metalbear-co#3438) * Fix typo in istio ambient message (metalbear-co#3439) * Fix typo in istio ambient message Fix typo in "! mirrord detected an ambient Istio service mesh butthe agent is not configured to run in a privileged SecurityContext.Please set `agent.privileged = true`, otherwise the agent will not be able to start." * add changelog entry --------- Co-authored-by: Scott Schulthess <[email protected]> * Enable passthrough mirroring by default in OSS (metalbear-co#3440) * Adjustment made * Changelog * Fix test * Fix config doc * Add mirrord newsletter command and periodic invitations to the newsletter (metalbear-co#3434) * Count user sessions and suggest newsletter signup after setup * implement persistent session count store * mirrord newsletter command * Change message content * Add changelog * Fix lint, nicer run count comparison * Apply suggestions * Fix output-dependent e2e test --------- Co-authored-by: Michał Smolarek <[email protected]> Co-authored-by: Scott Schulthess <[email protected]> Co-authored-by: Scott Schulthess <[email protected]> Co-authored-by: Gemma <[email protected]>
…r-co#3436) * initial commit. * oops. forgot -r * o_vec() for RegistryValue * format * start_ifeo * oops * simplify tests * cute little create_process * sync for the day * un-pub ifeo functions * simplify code * set up entrypoint for mirrord-layer * forgot git add * layer. * layer. * first simple version... * docs touchup * more logic touchups * oops * let hell loose * ughhh * FINALLY AHHH!! * here!!! * oops!! * finished!
| @@ -81,6 +84,15 @@ fn is_chrome_installed() -> bool { | |||
| .unwrap_or(false) | |||
| } | |||
|
|
|||
| #[cfg(windows)] | |||
| fn is_chrome_installed() -> bool { | |||
There was a problem hiding this comment.
this should be done through registry, i believe. i can help later. i have previous experience with this.
| @@ -0,0 +1,171 @@ | |||
| // mod common; | |||
There was a problem hiding this comment.
this deserves a thorough review before being merged, i believe. should we agree, i'll do it once the PR is ready for review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to mirrord!
Please make sure you added a CHANGELOG file in
changelog.d/namedissue_number.category.md.For example,
1054.changed.mdor+towncrier.added.md(if no issue).