3.x adjust localizeurl #934
Open
+486
−686
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 15 commits
December 18, 2024 21:40
Refactoring getLocalizedURL made a lot of code obsolete, especially parts related to translatedRoutes.
No longer needed after refactor of `getLocalizedURL`
…ansRoutes and handle in service
added 6 commits
March 22, 2025 00:15
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made changes to align
getLocalizedURLwith the new approach of receivinglocalevia middleware. This allowed me to significantly simplify the logic and remove a lot of what seemed unnecessary. However, I may have gone a bit too far—feedback is welcome!