Merge pull request #210 from DevFactory/release/collections.emptyList…

…-should-be-used-fix1 Fixing squid:S1596 - Collections.emptyList(), emptyMap() and emptySet() should be used instead of Collections.EMPTY_LIST, EMPTY_MAP and EMPTY_SET
maven-nar · Feb 25, 2016 · 3f8c317 · 3f8c317
2 parents e816d1c + a8f8e0f
commit 3f8c317
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/src/main/java/com/github/maven_nar/AbstractCompileMojo.java b/src/main/java/com/github/maven_nar/AbstractCompileMojo.java
@@ -214,7 +214,7 @@ protected final String getRuntime(final AOL aol) throws MojoExecutionException {
 
   protected final List getTests() {
     if (this.tests == null) {
-      this.tests = Collections.EMPTY_LIST;
+      this.tests = Collections.emptyList();
     }
     return this.tests;
   }

diff --git a/src/main/java/com/github/maven_nar/AbstractNarMojo.java b/src/main/java/com/github/maven_nar/AbstractNarMojo.java
@@ -236,7 +236,7 @@ protected final NarLayout getLayout() throws MojoExecutionException {
 
   protected final List<Library> getLibraries() {
     if (this.libraries == null) {
-      this.libraries = Collections.EMPTY_LIST;
+      this.libraries = Collections.emptyList();
     }
     return this.libraries;
   }

diff --git a/src/main/java/com/github/maven_nar/NarCompileMojo.java b/src/main/java/com/github/maven_nar/NarCompileMojo.java
@@ -417,7 +417,7 @@ protected ScopeFilter getArtifactScopeFilter() {
 
   private List getSourcesFor(final Compiler compiler) throws MojoFailureException, MojoExecutionException {
     if (compiler == null) {
-      return Collections.EMPTY_LIST;
+      return Collections.emptyList();
     }
 
     try {
@@ -431,7 +431,7 @@ private List getSourcesFor(final Compiler compiler) throws MojoFailureException,
       }
       return files;
     } catch (final IOException e) {
-      return Collections.EMPTY_LIST;
+      return Collections.emptyList();
     }
   }
 

diff --git a/src/main/java/com/github/maven_nar/cpptasks/apple/XcodeProjectWriter.java b/src/main/java/com/github/maven_nar/cpptasks/apple/XcodeProjectWriter.java
@@ -439,7 +439,7 @@ private PBXObjectRef addDependency(final Map objects, final PBXObjectRef project
         final PBXObjectRef referenceProxy = createPBXReferenceProxy(proxy, dependency);
         objects.put(referenceProxy.getID(), referenceProxy.getProperties());
 
-        final PBXObjectRef buildFile = createPBXBuildFile(referenceProxy, Collections.EMPTY_MAP);
+        final PBXObjectRef buildFile = createPBXBuildFile(referenceProxy, Collections.emptyMap());
         objects.put(buildFile.getID(), buildFile.getProperties());
 
         final List productsChildren = new ArrayList();