Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduced ESR maintenance overhead with file includes #7721

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Reduced ESR maintenance overhead with file includes #7721

wants to merge 7 commits into from

Conversation

cwarnermm
Copy link
Member

@cwarnermm cwarnermm commented Feb 3, 2025 •
edited
Loading

Reduced the number of pages to maintain for supported ESR updates down to the following 3 files:

  • /about/common-esr-support-rst.rst
  • /about/common-esr-support.md
  • /about/common-esr-support-upgrade.md

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 3, 2025

Newest code from mattermost has been published to preview environment for Git SHA f5c8985

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 3, 2025

Newest code from mattermost has been published to preview environment for Git SHA bc220e5

@cwarnermm
Copy link
Member Author

@amyblais - This docs PR reduces the number of places you're maintaining ESR support details across the docs site.

I've created 3 new common pages whose content can be referenced on other pages, as follows:

  • a short ESR support statement for .md docs files
  • a short ESR support statement for .rst docs files
  • a longer ESR server upgrade support statement for .md pages

Can I get your help to:

  • Confirm whether all of the docs pages that need ESR support updates are addressed. I'll update any I've missed.
  • Review each impacted page in this docs PR to ensure that ESR support details read as intended.
  • Let me know if you have any questions about maintaining this content going forward. I'm anticipating updates to the release playbook if the playbook calls out individual page-by-page changes needed today.

@cwarnermm cwarnermm requested a review from amyblais February 3, 2025 21:11
@cwarnermm cwarnermm added 2: Editor Review Requires review by an editor 2. SME Review labels Feb 3, 2025
amyblais
amyblais approved these changes Feb 4, 2025
View reviewed changes
source/about/common-esr-support-rst.rst Outdated Show resolved Hide resolved
source/about/common-esr-support-upgrade.md Outdated Show resolved Hide resolved
source/about/common-esr-support.md Outdated Show resolved Hide resolved
@amyblais amyblais added 3: Reviews Complete All reviewers have approved the pull request and removed 2: Editor Review Requires review by an editor 2. SME Review labels Feb 4, 2025
@amyblais
Copy link
Member

amyblais commented Feb 4, 2025

Thank you!!

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 4, 2025

Newest code from mattermost has been published to preview environment for Git SHA 62c7d94

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 4, 2025

Newest code from mattermost has been published to preview environment for Git SHA 76faf5f

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 4, 2025

Newest code from mattermost has been published to preview environment for Git SHA 5ff25e9

cwarnermm
cwarnermm commented Feb 4, 2025
View reviewed changes
source/about/common-esr-support-upgrade.md
@@ -0,0 +1,4 @@
- Support for Mattermost Server v9.11 [Extended Support Release](https://docs.mattermost.com/about/release-policy.html#extended-support-releases) is coming to the end of its life cycle on May 15, 2025. Upgrading to Mattermost Server v10.5 or later is required.
- Upgrading from ESR-to-ESR (``major`` -> ``major_next``) is fully supported and tested. However, upgrading from ESR-to-ESR (``major`` to ``major+2``) is supported, but not tested. If you plan to upgrade across multiple releases, we strongly recommend upgrading from an ESR to another ESR. For example, if you're upgrading from the v8.1 ESR, upgrade to the [v9.5 ESR](https://docs.mattermost.com/about/mattermost-v9-changelog.html#release-v9-5-extended-support-release) or the [v9.11 ESR](https://docs.mattermost.com/about/mattermost-v9-changelog.html#release-v9-11-extended-support-release).
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amyblais - Does the example here make sense? Or should it get bumped to v10.5 as well?

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 4, 2025

Newest code from mattermost has been published to preview environment for Git SHA 41acc0d

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 6, 2025

Newest code from mattermost has been published to preview environment for Git SHA 3cd290f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amyblais amyblais amyblais approved these changes

Assignees
No one assigned
Labels
3: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cwarnermm @amyblais