-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
_beforeToHtml DocBlock return type $this instead of string #39490
base: 2.4-develop
Are you sure you want to change the base?
_beforeToHtml DocBlock return type $this instead of string #39490
Conversation
Hi @lucafuser. Thank you for your contribution!
Allowed build names are:
You can find more information about the builds here For more details, review the Code Contributions documentation. |
@magento run all tests |
@magento create issue |
Hi @engcom-Hotel |
Manual testing is not required here, as this PR is only updating the doc block. Since the build is failing, moving it to Extended Testing. |
@magento run Functional Tests B2B, Functional Tests EE, Semantic Version Checker |
Description (*)
Changed _beforeToHtml DocBlock return type $this instead of string In Magento/Checkout/Block/Onepage/Success.php according to Magento/Framework/View/Element/AbstractBlock.php parent class.
Related Pull Requests
Fixed Issues (if relevant)
Manual testing scenarios (*)
Questions or comments
Contribution checklist (*)
Resolved issues: