Skip to content

Disable rounded corners for lyric window #2356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

3gf8jv4dv
Copy link
Contributor

Ensure that the lyric window looks the same on Windows 11 as it does on other systems.

Ref: electron/electron#46468

Resolves #2355

Ensure that the lyric window looks the same
on Windows 11 as it does on other systems.

Ref: electron/electron#46468
@lyswhut lyswhut linked an issue Apr 19, 2025 that may be closed by this pull request
@lyswhut
Copy link
Owner

lyswhut commented Apr 19, 2025

Is it possible to add this option to all calls to new BrowserWindow? You can search globally

This is used in the main window, lyrics window, and custom source.

@lyswhut lyswhut merged commit c2341d6 into lyswhut:dev Apr 19, 2025
1 check passed
@3gf8jv4dv
Copy link
Contributor Author

It looks good. But I am a little curious as to when this window for the User API (aka Custom Source) appears?

@lyswhut
Copy link
Owner

lyswhut commented Apr 19, 2025

It looks good. But I am a little curious as to when this window for the User API (aka Custom Source) appears?

It's always hidden, just added in passing

@3gf8jv4dv 3gf8jv4dv deleted the disable-rounded-corners-for-lyric-window branch April 19, 2025 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Lyrics window appears with border and shadow on 2.11.0-beta.5
2 participants