Terrain fixes

[akx]

First pass at some improvements to terrain loading:

• A better constructor for Ground – not one function that does two things, but a flat constructor and a loads-data-from-Mapbox one.
• Actual handling for Mapbox API errors (just panics for now, but better than trying to load an API error as an image)
• Refactoring of the Mapbox elevation data out of the Ground impl
• Removal of the hard-coded Mapbox access token (that just 401'd for me anyway).
  • If the access token was meant to be there (and I just happened to try it while the free quota was done with), it can be defaulted back in.
• Local caching of Mapbox tiles (faster once you've loaded them once, and no more token limits)
• For debugging, printing out the terrain heights (both from the raw data and the generated Minecraft blocks).
  • -> I think there's something wrong in the scaling math (that I didn't touch yet):

    Height data range: -0.299 to 64.64976453029676 m
    Minecraft height data range: -62 to -15 blocks

  • The generated map with this data is just flat :(

[louis-e]

Removal of the hard-coded Mapbox access token (that just 401'd for me anyway).
If the access token was meant to be there (and I just happened to try it while the free quota was done with), it can be defaulted back in.

Yup, my old token seems to have gotten revoked suddenly - I fixed that with a quick hotfix today.
Just wanted to point that out real quick, I'm still feeling a bit sick but I'll do a code review asap! :)

[akx]

@louis-e Get well soon! I can rebase this on top of the new stuff tomorrow or so, and make the CLI default to the hard-coded default token 👍

[github-actions]

⏱️ Benchmark run finished in 0m 38s
🧠 Peak memory usage: 1611 MB

📈 Compared against baseline: 42s
🧮 Delta: -4s
🔢 Commit: 71e28d1

🟢 Generation time is unchanged.

You can retrigger the benchmark by commenting retrigger-benchmark.

[louis-e]

retrigger-benchmark

[louis-e]

Hi there, thanks a lot for the great contribution! Especially the tile caching is amazing. I was already thinking about doing that via a proxy server, but turns out that is not allowed according to the Mapbox guidelines. So client side caching is a good idea.

I have to test it more thoroughly but one thing I saw is that you missed out returning the ground in pub fn generate_ground_data(args: &Args) -> Ground {

That might explain this :)

The generated map with this data is just flat :(