Update leisure and highway element processing #425
Conversation
Fix 'Mincraft' typo (Code still works so not sure what that prefix did) Add additional types for leisure
|
Seems that you need to run cargo fmt to format the files, and also run cargo clippy to check for any verbose or discouraged logic. |
Remove marina from water. It was making entire marina areas water, which was not intended. Add some block types to highways
GMart
changed the title
Fix nature_reserve Add more leisure values.
Fix GRASS to GRASS_BLOCK Remove ladder type as it would have to have special properties to work properly
|
Hi there, thanks a lot for your first contribution! :)
Woah, I have no clue when that typo was introduced. Never noticed that before in the code. Thanks!
Nice, underground structures? If you want to get this PR merged sooner, feel free to open that in a seperate PR. Otherwise you can also mark this PR as a draft and push your other updates into this. |
|
retrigger-benchmark |
|
⏱️ Benchmark run finished in 2m 14s 📈 Compared against baseline: 130s 🟢 Generation time is unchanged. You can retrigger the benchmark by commenting |
|
@louis-e, |
In Leisure, soccer golf is used less than 1000 time worldwide. Removed since it will rarely be used. in highways, changes stairs to be GRAY_CONCRETE for now, until they are properly added.
Add comments to code, add dirt to option for dog park, playground, etc.
|
retrigger-benchmark hmmm... Didn't work. |
|
FYI the trigger updates the last benchmark comment. |
Hi Louis,
This is my first time contributing to a Rust project.
I noticed a few things I could add while still learning the Rust syntax.