chore(kad_dht): centralize shared values in common.py file

[LVivona]

What was wrong?

The kad_dht module contained repeated definitions of commonly used variables, leading to redundancy and reduced maintainability.

How was it fixed?

A new common.py file was introduced to centralize shared default values and constants, promoting reuse and improving code clarity.

To-Do

• Clean up commit history
• Add or update documentation related to these changes
• Add entry to the release notes

Cute Animal Picture

[sumanjeet0012]

@LVivona The code looks clean and well-structured.
I’ve shared a few suggestions which may be addressed.

[sumanjeet0012]

You can use PROTOCOL_ID directly in the stream creation statement:
stream = await self.host.new_stream(peer_id, [PROTOCOL_ID])
This makes the assignment protocol_id = PROTOCOL_ID unnecessary and can be removed.

[LVivona]

Within peer_routing.py there exist PROTOCOL_ID as well, should I set it to just PROTOCOL_ID, or is it necessary within the state of the object PeerRouting

PeerRouting

    def __init__(self, host: IHost, routing_table: RoutingTable):
        """
        Initialize the peer routing service.

        :param host: The libp2p host
        :param routing_table: The Kademlia routing table

        """
        self.host = host
        self.routing_table = routing_table
        self.protocol_id = PROTOCOL_ID

[sumanjeet0012]

@LVivona Since PROTOCOL_ID is now defined in common.py, it can be imported and used as a global constant wherever needed. Therefore, there is no longer a need to store it in the state of the PeerRouting object.

So you can remove self.protocol_id = PROTOCOL_ID and use PROTOCOL_ID directly wherever applicable.

[LVivona]

Okay perfect

[sumanjeet0012]

Import this using the multiline import style to maintain consistency

[LVivona]

My bad I'm not sure how I missed that one.

[LVivona]

While running the workflow locally, I noticed there was a test tests/core/kad_dht/test_unit_peer_routing.py that asserted the attribute protocol_id. Since it’s no longer used, I removed that assertion from the test.

[sumanjeet0012]

@LVivona The pull request looks good to me. All requested changes have been addressed.

[sumanjeet0012]

@seetadev All feedback has been addressed. Please run the CI/CD tests, and if all tests pass, we can proceed with merging the pull request.