fix: improve async validator handling in Pubsub class #683
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: varun-r-mallya <[email protected]>
|
@varun-r-mallya : Nice work on the PR. Appreciate your efforts and initiative. Reviewing it. Kindly update #647 with your implementation notes. CCing @pacrob , @sumanjeet0012 and @mystical-prog for their review too. |
|
@seetadev like Varun rightly mentioned that appends in CPython are thread safe, this change looks completely fine to me, if we were operating on the appended values in that scenario it would have been vulnerable to multi-thread environment but since that is not the case here - I believe it's good to go |
|
Looks good, @varun-r-mallya! Please add a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Issue #682
How was it fixed?
By using an aggregator list instead of a variable to
andwithTo-Do