-
Notifications
You must be signed in to change notification settings - Fork 147
initial-setup of py-webrtc #557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Just a note, py-libp2p is using |
@pacrob noted, will modify, thanks! |
New Commit entails the following changes:-🔧
|
Commit: refactor-webrtc-setup-and-loopback-testDescription- Key improvements to the` webrtc.py` file in the `libp2p.transport.webrtc` module:
✅ ICE Trickling: Implemented and now symmetric (caller/callee) Updates:
Troubleshooting ahead:
Test_loopback.py Result:Lint Run Result: All lint issues fixed except
|
@Nkovaturient : Great progress. Please try and arrive at a good conclusion on the issues by Thursday. |
@seetadev yeah, updating you shortly. |
@seetadev
|
@Nkovaturient : Thank you so much for sharing the updates and code commits. Appreciate your contribution. Wish if you could debug some of the build issues that are not passing after running the latest CI/CD checks. Wish to also share that I discussed with rust-libp2p team on webrtc and documented a test plan for webrtc fallback relay testing matrix : #601 Please keep in touch with @Winter-Soren as he implements circuit relay and hole punching (support needed for webrtc in production). |
@seetadev Sure, actively working on the build issues + test suite |
… add-webrtc-in-pylibp2p
… add-webrtc-in-pylibp2p
@Nkovaturient : We are almost through with the circuit relay PR. @Winter-Soren and I will be moving over to hole punching initiative in the coming week. Will keep you posted. This will help you have the requisite NAT Traversal stack required in WebRTC. Autonat is complete and productionized. @Winter-Soren has ensured NAT Traversal features are production ready. Please try AutoNAT functionality, which is fully ready: please visit autonat implementation video and testcases video |
@seetadev humbly appreciate ur updates! Im taking care of it. |
… add-webrtc-in-pylibp2p
What was wrong?
Issue #546
Implementations & Enhancements
(RTCPeerConnection)
for direct communication.SDP
exchange via aWebSocket-based signaling server
(listen_signaling).(RTCDataChannel)
for efficient peer-to-peer messaging.WebSockets
are used for signaling to register and communicate SDP offers/answers.peer discovery
(initiate_connection).GossipSub
to enable decentralized peer advertisement & discovery.multiaddr
parsing for WebRTC protocolsQuestions
1.) Should we rely entirely on WebSockets for signaling, or use DHT as a fallback?
2)Multiaddr Handling & Validation
3.)Peer Discovery Optimization
To-Do
Helpful resources
js-libp2p-webrtc
go-libp2p-webrtc