[Merged by Bors] - feat(RingTheory/Ideal): more lemmas about the height of an ideal #21041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ithub.com/leanprover-community/mathlib4 into xyzw12345_porting_Andrew_AG_morphism_rank
…ithub.com/leanprover-community/mathlib4 into xyzw12345_porting_Andrew_AG_morphism_rank
…ithub.com/leanprover-community/mathlib4 into xyzw12345_porting_Andrew_AG_morphism_rank
…ithub.com/leanprover-community/mathlib4 into xyzw12345_porting_Andrew_AG_morphism_rank
…ithub.com/leanprover-community/mathlib4 into xyzw12345_porting_Andrew_AG_morphism_rank
…ithub.com/leanprover-community/mathlib4 into xyzw12345_porting_Andrew_AG_morphism_rank
Co-authored-by: Christian Merten <[email protected]>
Co-authored-by: Christian Merten <[email protected]>
Co-authored-by: Christian Merten <[email protected]>
Co-authored-by: Christian Merten <[email protected]>
Co-authored-by: Christian Merten <[email protected]>
Co-authored-by: Christian Merten <[email protected]>
Co-authored-by: Christian Merten <[email protected]>
xyzw12345
removed
the
awaiting-author
|
Thanks for all the review comments! |
chrisflav
approved these changes
Mar 11, 2025
|
🚀 Pull request has been placed on the maintainer queue by chrisflav. |
|
For the record: The |
jcommelin
reviewed
Mar 11, 2025
Co-authored-by: Johan Commelin <[email protected]>
Co-authored-by: Johan Commelin <[email protected]>
|
Thanks 🎉 bors merge |
leanprover-community-mathlib4-bot
added
ready-to-merge
mathlib-bors bot
pushed a commit
that referenced
this pull request
Mar 13, 2025
) In this PR, we continue to port a part of Andrew Yang's lean3 repository at [this repository](https://github.com/erdOne/lean-AG-morphisms), which is appoved by @erdOne after his discussion with @chrisflav . This PR follows #20741 (merged by Bors) and #20744. We ported Andrew's definition of `Ideal.height` and `Ideal.primeHeight` with some small changes in #20741, and in this PR, we ported some more lemmas about these definitions, finishing the porting work of dimension_theory/height.lean in that repository. - [x] depends on: #20744 [some of the lemmas used spanRank] - [x] depends on: #22236 [We separated the lemmas about `Order.height` and `krullDim` to this PR] Co-authored-by: @erdOne @Xuchun-Li [[email protected]](mailto:[email protected]) @jjdishere [[email protected]](mailto:[email protected]) @Blackfeather007 [[email protected]](mailto:[email protected]) @ShouxinZhang [[email protected]](mailto:[email protected])
|
Build failed (retrying...): |
|
Canceled. |
|
bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Mar 13, 2025
) In this PR, we continue to port a part of Andrew Yang's lean3 repository at [this repository](https://github.com/erdOne/lean-AG-morphisms), which is appoved by @erdOne after his discussion with @chrisflav . This PR follows #20741 (merged by Bors) and #20744. We ported Andrew's definition of `Ideal.height` and `Ideal.primeHeight` with some small changes in #20741, and in this PR, we ported some more lemmas about these definitions, finishing the porting work of dimension_theory/height.lean in that repository. - [x] depends on: #20744 [some of the lemmas used spanRank] - [x] depends on: #22236 [We separated the lemmas about `Order.height` and `krullDim` to this PR] Co-authored-by: @erdOne @Xuchun-Li [[email protected]](mailto:[email protected]) @jjdishere [[email protected]](mailto:[email protected]) @Blackfeather007 [[email protected]](mailto:[email protected]) @ShouxinZhang [[email protected]](mailto:[email protected])
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, we continue to port a part of Andrew Yang's lean3 repository at this repository, which is appoved by @erdOne after his discussion with @chrisflav . This PR follows #20741 (merged by Bors) and #20744.
We ported Andrew's definition of
Ideal.heightandIdeal.primeHeightwith some small changes in #20741, and in this PR, we ported some more lemmas about these definitions, finishing the porting work of dimension_theory/height.lean in that repository.Order.height,Order.coheightandkrullDim#22236 [We separated the lemmas aboutOrder.heightandkrullDimto this PR]Co-authored-by:
@erdOne
@Xuchun-Li [email protected]
@jjdishere [email protected]
@Blackfeather007 [email protected]
@ShouxinZhang [email protected]