Update milvus.py

[bleuzetim]

Allows to use connection_args as followed

vectordb = Milvus(
collection_name="my_milvus_collection",
connection_args={"host": host_name, "port": port_name}
)

[codingjaguar]

Nit, the code didn't check the existence of port from input params. The checking probably can be more robust.

Discussion: in Milvus we are recommending using URI and TOKEN universally. Is that feasible to construct uri on the caller side?

[bleuzetim]

It does check the existence, if a port parameter is given it will use itm otherwise it will default it to 19530. I do agree that i might need to check the port better. (In code he checks wether the host is given, because i suppose people wont only send a port with the connection_args but always send a host with the port)

I think both the option for URI and host/port are nice to have.

Note: Co-Pilot, ChatGPT will often use the host/port way and not the URI way. Implementing this will help people who often use GPT to have less errors. (Usefull but need to make it more robustly coded)

[codingjaguar]

Thanks for the context! That makes sense to me. I think we can keep supporting both URI and host:port to be consistent with current Milvus implementation.

/lgtm

@zc277584121 PTAL.

[zc277584121]

@bleuzetim @codingjaguar I don't think this is a good way, because the milvus client does not support host + port manner. We should be consistent with milvus client SDK. As for the ChatGPT's answer, I think it 's caused by the hallucinations or old depracated knowledge in the Internet. For reduce the depracated usage demo, we should not accept this manner.